[PERF] Actions: Fill missing ids with fast unique values #5029
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
src/actions/action.ts
Outdated
| @@ -92,6 +92,7 @@ export function createActions(menuItems: ActionSpec[]): Action[] { | |||
| } | |||
|
|
|||
| const uuidGenerator = new UuidGenerator(); | |||
| uuidGenerator.setIsFastStrategy(true); | |||
There was a problem hiding this comment.
let's just use a incremented number here then. Instead of instantiating a UuidGenerator for no apparent reason.
Or it's the beginning of the enterprise fizzbuzz 😄
The ActionsSpecs have a defaut behaviour where we are not obligated to provide an id in the actionSpec because "CreateAction" will end up generating it on demand with an uuidv4. However, uuidv4 can become a problem if invoked to often and it so happens that some actionSpecs related to the topbar benefit from this automatic generation. Since the topbar items are regenerated at each rendering of a spreadsheet, they can become problematic. For instance, in Odoo test suites, they take up to 2-3% of the computation time. This revision replaces the call to uuidv4 by a simple incremented integer which still guarantees the uniqueness of the identifier. Task: 4216427
rrahir
force-pushed
the
saas-17.4-fast-menu-item-id-rar
branch
from
60cd0db
to
03d348a
Compare
I was asking myself the same question, I think that for the time being it's quite controlled. each render was below 10 calls to UUIDGenerator and seeing the value of max integer, it seems safe :D. If it starts growing too much at some point, we can always force the id later on. As I said, i don't think it's too much of a bother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActionsSpecs have a defaut behaviour where we are not obligated to provide an id in the actionSpec because "CreateAction" will end up generating it on demand with an uuidv4.
However, uuidv4 can become a problem if invoked to often and it so happens that some actionSpecs related to the topbar benefit from this automatic generation. Since the topbar items are regenerated at each rendering of a spreadsheet, they can become problematic.
For instance, in Odoo test suites, they take up to 2-3% of the computation time.
This revision bypasses the call to an actual uuidv4 by forcing a fast strategy in the uuidGenerator, which accomplishes the same result, having a unique identifier for each menu item generated.
Task: 4216427
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist