Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Actions: Fill missing ids with fast unique values #5029

Closed
wants to merge 1 commit into from
Closed

[PERF] Actions: Fill missing ids with fast unique values #5029

wants to merge 1 commit into from
+3 −5

Commits on Sep 27, 2024

  1. [PERF] Actions: Fill missing ids with fast unique values 

    The ActionsSpecs have a defaut behaviour where we are not obligated
to provide an id in the actionSpec because "CreateAction" will end up
generating it on demand with an uuidv4.

However, uuidv4 can become a problem if invoked to often and it so
happens that some actionSpecs related to the topbar benefit from this
automatic generation. Since the topbar items are regenerated at each
rendering of a spreadsheet, they can become problematic.

For instance, in Odoo test suites, they take up to 2-3% of the
computation time.

This revision replaces the call to uuidv4 by a simple incremented
integer which still guarantees the uniqueness of the identifier.

Task: 4216427
    @rrahir
    rrahir committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    03d348a View commit details
    Browse the repository at this point in the history