Use Maven profiles to handle different versions of TestNG #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For JDK8, bump org.testng:testng to the last supported release for this version i.e. 7.5 For JDK11+, bump org.testng:testng to the latest release 7.9.0
melissalinkert
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Makes sense to me, and it's encouraging that all of the matrix builds passed. We probably need the same change in:
- https://github.com/ome/bioformats
- Bump testng from 6.8 to 7.7.0 ome-codecs#24
- https://github.com/ome/ome-model
- https://github.com/ome/ome-metakit
and then 4 days of passing https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-repo/ before merging?
|
👍 I'll try and open similar testng PRs against all repositories mentioned above tomorrow. If everything goes well, we should be in a position to integrate all of the JDK 21 related PRs at next Monday's Formats meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #72 using the strategy discussed in ome/bioformats#4159 (comment)