Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eusm commodity create Update #1330

Merged
merged 37 commits into from
Feb 28, 2024
Merged

Eusm commodity create Update #1330

merged 37 commits into from
Feb 28, 2024

Conversation

peterMuriuki
Copy link
Collaborator

@peterMuriuki peterMuriuki commented Feb 15, 2024

closes #1328

Enable Creating and editing Eusm - style supply chain commodities.

  • Refactors productForm to add other fields required by EUSM.
  • Add container view to render add edit view for the commodity.

Checklist

  • tests are included and passing
  • documentation is changed or added
  • Internationalization:
    • Ensure all strings are internationalized.
  • Role-Based Access:
    • Verify that all user actions have appropriate role-based access permissions set.

@peterMuriuki peterMuriuki marked this pull request as ready for review February 19, 2024 06:42
@peterMuriuki
Copy link
Collaborator Author

Screenshot from 2024-02-22 14-36-28
Screenshot from 2024-02-22 14-35-52
Screenshot from 2024-02-22 14-35-40

@@ -51,7 +51,22 @@ Object.defineProperty(window, 'location', {
},
writable: true,
});
window.__PRELOADED_STATE__ = { random: 'Preloaded state, baby!' };

function toArrayBuffer(buffer) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain this. You might also consider adding a docstring here. It's not immediately clear how and why it's used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it should go to utils?

machariamuguku
machariamuguku previously approved these changes Feb 27, 2024
Base automatically changed from 1328-eusm-commodity-rd to main February 28, 2024 07:30
@peterMuriuki peterMuriuki dismissed machariamuguku’s stale review February 28, 2024 07:30

The base branch was changed.

@peterMuriuki peterMuriuki merged commit 2f590a0 into main Feb 28, 2024
1 of 2 checks passed
@peterMuriuki peterMuriuki deleted the 1328-eusm-commodity-cu branch February 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EUSM]: Adapt the Commodity module for products in EUSM
2 participants