-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add RNN examples #1905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR.
Could you please change the commit names to align with oneDNN contribution guidelines?
Something like:
examples: add vanilla_rnn example
examples: add lbr_gru example
Could you also please add reference to those examples in the documentation? (at the end of file doc/primitives/rnn.md)
Thanks you!
2de0409
to
a44e294
Compare
Thanks for reviewing. I have updated the commit messages and also added reference to those examples in the documentation. |
a44e294
to
f7cf55d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Description
Add examples for Vanilla RNN and Linear-before-reset GRU RNN by referring to the RNN descriptions in oneDNN documentation.
For lbr_gru, the gates order is update, reset and output gate, and there is an extra bias for u' gate.
Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?