Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add RNN examples #1905

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

shu1chen
Copy link
Contributor

@shu1chen shu1chen commented May 9, 2024

Description

Add examples for Vanilla RNN and Linear-before-reset GRU RNN by referring to the RNN descriptions in oneDNN documentation.
For lbr_gru, the gates order is update, reset and output gate, and there is an extra bias for u' gate.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR.
Could you please change the commit names to align with oneDNN contribution guidelines?
Something like:
examples: add vanilla_rnn example
examples: add lbr_gru example

Could you also please add reference to those examples in the documentation? (at the end of file doc/primitives/rnn.md)

Thanks you!

examples/primitives/vanilla.cpp Outdated Show resolved Hide resolved
examples/primitives/vanilla.cpp Outdated Show resolved Hide resolved
examples/primitives/lbr_gru.cpp Outdated Show resolved Hide resolved
@shu1chen
Copy link
Contributor Author

Thanks for reviewing. I have updated the commit messages and also added reference to those examples in the documentation.

@shu1chen shu1chen changed the title examples: Add RNN examples examples: add RNN examples May 13, 2024
Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mgouicem mgouicem merged commit db32fc4 into oneapi-src:main May 13, 2024
10 checks passed
@shu1chen shu1chen deleted the add_rnn_examples branch May 13, 2024 14:36
@vpirogov vpirogov added the enhancement A feature or an optimization request label May 21, 2024
@vpirogov vpirogov added this to the v3.6 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or an optimization request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants