Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build llvm with clang since gcc on ppc64le doesn't support __builtin_thread_pointer #2379

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

gongsu832
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please just confirm that we now build LLVM using clang on all CIs using docker, namely s390, power, and linux x86.

@AlexandreEichenberger
Copy link
Collaborator

@gongsu832 thanks for the quick turnaround!

@gongsu832
Copy link
Collaborator Author

LLVM on all archs are built with clang. onnx-mlir must also be built with clang. Otherwise, a lot of lit tests crash.

@gongsu832 gongsu832 merged commit 63f7e41 into onnx:main Jul 19, 2023
4 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12007 [push] Build llvm with clang si... started at 10:30

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #11994 [push] Build llvm with clang si... started at 09:30

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11001 [push] Build llvm with clang si... started at 10:36

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #11994 [push] Build llvm with clang si... passed after 1 hr 57 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12007 [push] Build llvm with clang si... passed after 2 hr 28 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11001 [push] Build llvm with clang si... passed after 3 hr 7 min

negiyas pushed a commit to negiyas/onnx-mlir that referenced this pull request Jul 31, 2023
…thread_pointer (onnx#2379)

* Build llvm with clang since gcc on ppc64le doesn't support __builtin_thread_pointer
* Install clang for ubi8
* Compile onnx-mlir with clang
* Don't remove diffutils and make on ubi8 since clang depends on them

Signed-off-by: Gong Su <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants