Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDEVSTC-291 - Coverage Projection #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CIDEVSTC-291 - Coverage Projection #155

wants to merge 2 commits into from

Conversation

lukecampbell
Copy link
Member

Adds the ability to reference external coverages.

Necessary for:

  • Colocated instrument in data processing
  • Geospatial information from platform onto instrument.

- Adds _pdir to param contexts for pfuncs
- Adds new pfunc type: ExternalParameterFunction
- Basic support for external "gets"
- Adds in the linear interpolation
- Adds test to verify it projects correctly
@lukecampbell
Copy link
Member Author

@mmeisinger Please review

@lukecampbell
Copy link
Member Author

I want to point out some MAJOR shortcomings of this initial pull request.

  • Depends on the data being SORTED (np.searchsorted is used), we'll have to refine it to make a much slower algorithm for the unsorted datasets.
  • Data points that exist outside the domain are extrapolated using the last two data points and a linear model.
  • This is going to completely fall apart when we get to M193

@lukecampbell
Copy link
Member Author

Background

  1. Colocated L2 Data Products
  2. Lat and Lon for AUV/Gliders

Some of the particulars of the use case for this got flushed out in a meeting a few weeks back:

  • I think we'll need to include not only a reference to another coverage but a window.
    • reference_id
    • extents (that are potentially open)

Initially the parameter will not have any references and should return all NaNs for each time-step in the local domain (the domain of the coverage this parameter belongs to). Once a device is deployed, we'll know which instrument is in proximity and should be referenced.

I believe, that we'll add logic inside activate_deployment that will identify a CTD on the same platform and then identify any parameters within the dataset/coverage that are of this type (ExternalFunction) and then add a reference to that parameter and the window of the deployment.

The same can be said about latitude and longitude.

caseybryant added a commit to caseybryant/coverage-model that referenced this pull request Jul 7, 2014
@caseybryant
Copy link
Contributor

This pull request should be closed without merging. It was replaced by #194. #195 has been created to capture edge cases that haven't been handled yet.
@lukecampbell Do you want to document any edge cases missing in #195 and close this PR?

@lukecampbell
Copy link
Member Author

Once I get into the integration more, I'll look to document missing edge cases but, I feel the core of it is there and will meet our needs. I definitely need to think through the big picture and how this plays into multiple deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants