-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIDEVSTC-291 - Coverage Projection #155
base: master
Are you sure you want to change the base?
Conversation
- Adds _pdir to param contexts for pfuncs - Adds new pfunc type: ExternalParameterFunction - Basic support for external "gets"
- Adds in the linear interpolation - Adds test to verify it projects correctly
@mmeisinger Please review |
I want to point out some MAJOR shortcomings of this initial pull request.
|
Background
Some of the particulars of the use case for this got flushed out in a meeting a few weeks back:
Initially the parameter will not have any references and should return all NaNs for each time-step in the local domain (the domain of the coverage this parameter belongs to). Once a device is deployed, we'll know which instrument is in proximity and should be referenced. I believe, that we'll add logic inside activate_deployment that will identify a CTD on the same platform and then identify any parameters within the dataset/coverage that are of this type (ExternalFunction) and then add a reference to that parameter and the window of the deployment. The same can be said about latitude and longitude. |
This pull request should be closed without merging. It was replaced by #194. #195 has been created to capture edge cases that haven't been handled yet. |
Once I get into the integration more, I'll look to document missing edge cases but, I feel the core of it is there and will meet our needs. I definitely need to think through the big picture and how this plays into multiple deployments. |
Adds the ability to reference external coverages.
Necessary for: