Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Parameters Implemented #194

Merged
merged 5 commits into from
Jul 7, 2014
Merged

Conversation

caseybryant
Copy link
Contributor

This pull request replaces PR #155

@caseybryant
Copy link
Contributor Author

@lukecampbell Want to take a look at this and try it out?

@lukecampbell
Copy link
Member

I'm looking at it now, looks good.

@caseybryant
Copy link
Contributor Author

The idea is that we move the interpolation function out of coverage purview so you can do whatever you want with it. I provided a linear interpolation default inside of coverage that you can use/modify for now.

If you like it, I will add the ability to ask for next X number of data points on each side of the window to help with interpolation. I didn't add it already because I'm still working out some edge cases.

@lukecampbell
Copy link
Member

Looks good, let me know when I can merge it. My plan is to have it merged soon (if we can) and then I'll have Bob work on M086 which leverages the ability to reference data within adjacent datasets. He'll take over the rest of this integration effort into coi-services.

@caseybryant
Copy link
Contributor Author

You can merge as-is. I can check something in for the edge cases later. I'll make an issue to have coverage support collecting neighboring temporal data-points.

@lukecampbell
Copy link
Member

Awesome!

lukecampbell added a commit that referenced this pull request Jul 7, 2014
External Parameters Implemented
@lukecampbell lukecampbell merged commit 221e3ff into ooici:master Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants