-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Parameters Implemented #194
Conversation
@lukecampbell Want to take a look at this and try it out? |
I'm looking at it now, looks good. |
The idea is that we move the interpolation function out of coverage purview so you can do whatever you want with it. I provided a linear interpolation default inside of coverage that you can use/modify for now. If you like it, I will add the ability to ask for next X number of data points on each side of the window to help with interpolation. I didn't add it already because I'm still working out some edge cases. |
Looks good, let me know when I can merge it. My plan is to have it merged soon (if we can) and then I'll have Bob work on M086 which leverages the ability to reference data within adjacent datasets. He'll take over the rest of this integration effort into coi-services. |
You can merge as-is. I can check something in for the edge cases later. I'll make an issue to have coverage support collecting neighboring temporal data-points. |
Awesome! |
External Parameters Implemented
This pull request replaces PR #155