Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Waymo create_data/loading/evaluation speed up #2705

Closed
wants to merge 21 commits into from

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sunjiahao1999
❌ sjh


sjh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (12b595c) 46.70% compared to head (b647aa1) 47.01%.

❗ Current head b647aa1 differs from pull request most recent head 651dbf1. Consider uploading reports for the commit 651dbf1 to get more accurate results

Files Patch % Lines
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% 27 Missing ⚠️
mmdet3d/datasets/waymo_dataset.py 11.11% 24 Missing ⚠️
mmdet3d/evaluation/metrics/waymo_metric.py 11.76% 15 Missing ⚠️
mmdet3d/datasets/convert_utils.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2705      +/-   ##
===========================================
+ Coverage    46.70%   47.01%   +0.31%     
===========================================
  Files          277      277              
  Lines        23633    23371     -262     
  Branches      3704     3640      -64     
===========================================
- Hits         11038    10989      -49     
+ Misses       11891    11688     -203     
+ Partials       704      694      -10     
Flag Coverage Δ
unittests 47.01% <13.41%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tai-Wang
Copy link
Member

Please add more detailed information, including the modification and benchmark, in the PR message box.

@@ -187,12 +188,15 @@
dict(
type='PointsRangeFilter', point_cloud_range=point_cloud_range)
]),
dict(type='Pack3DDetInputs', keys=['points'])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add it in all waymo related config

tools/dataset_converters/waymo_converter.py Show resolved Hide resolved
@Tai-Wang Tai-Wang closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants