Update structures.ops.transforms.bbox3droi
#3074
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The method,
structures.ops.transforms.bbox3droi
returns rois as a tensor. There was a condition that led to returns of tensors with 7 or 8 size on dim 1 depending on the fulfillment of the condition. The change fixes the shape to 8 without any other changes. This is necessary because the downstream modules that use this output expect a size of 8 on dim 1 not 7. SeeSingle3DRoIPointExtractor.forward
Modification
The change fixes the shape of the return of
structures.ops.transforms.bbox3droi
to 8 on dim 1 without any other changes. This is necessary because the downstream modules that use this output expect a size of 8 on dim 1 not 7. SeeSingle3DRoIPointExtractor.forward
BC-breaking (Optional)
No since all the downstream users of this method expect a size of 8 on dim 1 for rois, 1 for image index in batch and rest 7 for the bbox attributes.
Checklist