[chore] [processor/groupbyattrs] clarify compaction occurs even when no key matches #31027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
changed the title
djaglowski
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
LGTM, but let's give a chance for @rnishtala-sumo to review as code owner.
TylerHelmuth
approved these changes
Feb 13, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…no key matches (open-telemetry#31027) I expected the processor to be a complete no-op if no attribute keys match, but I noticed that it still does perform compaction, as if the processor was configured with an empty config (no keys). In some sense it feels like having both grouping and compaction features in one processor is confusing, but it's not that bad in practice but this doc clarification can make it less surprising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expected the processor to be a complete no-op if no attribute keys match, but I noticed that it still does perform compaction, as if the processor was configured with an empty config (no keys). In some sense it feels like having both grouping and compaction features in one processor is confusing, but it's not that bad in practice but this doc clarification can make it less surprising.