chore: Update CODEOWNERS for helper gems #879
Conversation
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi and
xuan-cao-swi
as code owners
| @@ -31,3 +31,7 @@ instrumentation/racecar/ @chrisholmes @open-telemetry/ruby-contrib-maintainers @ | |||
| instrumentation/rspec/ @chrisholmes @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi | |||
|
|
|||
| instrumentation/que/ @indrekj @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi | |||
|
|
|||
| helpers/mysql/ @kaylareopelle @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi | |||
There was a problem hiding this comment.
he he... so nice you are adding your name twice?
There was a problem hiding this comment.
lol, yeah, I'm not sure if that makes sense! I'm happy to just close this, but it was a thought in my mind since the lambda PR requested a codeowner even though they're also part of the maintainers/approvers.
There was a problem hiding this comment.
Good point. I am not sure how to disambiguate the "owner" vs the reviewers.
Maybe we should follow the pattern in otelcol-contrib where the Readme files have an auto generated section:
Status Stability [beta]: traces, metrics, logs Distributions [contrib], [observiq], [splunk], [sumo] Issues 
Code Owners @rnishtala-sumo
There was a problem hiding this comment.
I'm open to that approach! Should we make this consistent throughout the gems?
There was a problem hiding this comment.
If you're up for it sure!
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
@arielvalentin, I'm going to close this PR in favor of #916 to address this for all repos at once. |
I think this may have been a follow-up on #529 that got missed