Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CODEOWNERS for helper gems #879

Closed
wants to merge 2 commits into from
+4 −0
Closed

chore: Update CODEOWNERS for helper gems #879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23e0d8b
chore: Update CODEOWNERS for helper gems
kaylareopelle Feb 20, 2024
aa991d9
Merge branch 'main' into update-helpers-codeowners
arielvalentin Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,7 @@ instrumentation/racecar/ @chrisholmes @open-telemetry/ruby-contrib-maintainers @
instrumentation/rspec/ @chrisholmes @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi

instrumentation/que/ @indrekj @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi

helpers/mysql/ @kaylareopelle @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he he... so nice you are adding your name twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, yeah, I'm not sure if that makes sense! I'm happy to just close this, but it was a thought in my mind since the lambda PR requested a codeowner even though they're also part of the maintainers/approvers.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I am not sure how to disambiguate the "owner" vs the reviewers.

Maybe we should follow the pattern in otelcol-contrib where the Readme files have an auto generated section:

Status
Stability [beta]: traces, metrics, logs
Distributions [contrib], [observiq], [splunk], [sumo]
Issues Open issues Closed issues
Code Owners @rnishtala-sumo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to that approach! Should we make this consistent throughout the gems?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're up for it sure!


helpers/sql-obfuscation/ @kaylareopelle @open-telemetry/ruby-contrib-maintainers @open-telemetry/ruby-contrib-approvers @fbogsany @mwear @robertlaurin @dazuma @ericmustin @arielvalentin @ahayworth @plantfansam @robbkidd @simi @kaylareopelle @xuan-cao-swi