Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task transform #409

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix task transform #409

merged 1 commit into from
Aug 22, 2024

Conversation

kkoehn
Copy link
Collaborator

@kkoehn kkoehn commented Jul 23, 2024

fixes some not respected cases and edge cases

  • When importing the xml and converting some data through dachsfisch it cannot be assume, that an Array is formed, when only one object is present in a list.

  • external-resource did not get cleaned

  • file-restriction attribute @use is not required

@kkoehn kkoehn added bug Something isn't working ruby Pull requests that update Ruby code labels Jul 23, 2024
@kkoehn kkoehn self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (49216a4) to head (1c49eb9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         1418      1487   +69     
=========================================
+ Hits          1418      1487   +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a brief moment to validate the changes within the given domain: They look fine and valid. However, doing so was quite challenging for me, since I feel there is also no clear change log between ProFormA 2.0 and 2.1. Nevertheless, the code gave me enough information to dig through the schema files on my own and spot the differences.

Code-wise, I am leaving the review for @Dome-GER. I am unsure about potential improvements, this looks rather complex overall. Now, there seem some minor code duplicates (such as ensuring we have an array for external resources and submission restrictions)...

@kkoehn kkoehn force-pushed the fix-task-transform branch 3 times, most recently from 5c81839 to 961d744 Compare July 30, 2024 22:12
lib/proformaxml/services/transform_task.rb Outdated Show resolved Hide resolved
@Dome-GER Dome-GER merged commit 524fad1 into main Aug 22, 2024
7 checks passed
@Dome-GER Dome-GER deleted the fix-task-transform branch August 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants