-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task transform #409
Fix task transform #409
Conversation
919bbb0
to
86dc84b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 1418 1487 +69
=========================================
+ Hits 1418 1487 +69 ☔ View full report in Codecov by Sentry. |
86dc84b
to
7f916c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a brief moment to validate the changes within the given domain: They look fine and valid. However, doing so was quite challenging for me, since I feel there is also no clear change log between ProFormA 2.0 and 2.1. Nevertheless, the code gave me enough information to dig through the schema files on my own and spot the differences.
Code-wise, I am leaving the review for @Dome-GER. I am unsure about potential improvements, this looks rather complex overall. Now, there seem some minor code duplicates (such as ensuring we have an array for external resources and submission restrictions)...
5c81839
to
961d744
Compare
961d744
to
9886136
Compare
9886136
to
554b23f
Compare
554b23f
to
1c49eb9
Compare
fixes some not respected cases and edge cases
When importing the xml and converting some data through dachsfisch it cannot be assume, that an Array is formed, when only one object is present in a list.
external-resource did not get cleaned
file-restriction attribute
@use
is not required