Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification display in event metadata tab #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Dec 18, 2024

Fixes #947.

Notifications were not being rendered in the metadata tab of the event details, especially the "Active Workflow"-notification. This patch fixes that.

This patch also fixes:

  • The "Active Workflow"-notification being rendered multiple times.
  • The "Active Workflow"-notification being rendered even when there is no active workflow anymore.

How to test this

Can be tested as usual, no configuration or Opencast patch necessary. To test, start a workflow on an event and open the event details. Then click through the tabs a bit.

Bildschirmfoto vom 2024-12-18 15-13-44

Notifications were not being rendered in the
metadata tab of the event details, especially the
"Active Workflow"-notification. This patch fixes that.

This patch also fixes:
- The "Active Workflow"-notification being rendered
multiple times.
- The "Active Workflow"-notification being
rendered even when there is no active workflow
anymore.
@Arnei Arnei added the type:bug Something isn't working label Dec 18, 2024
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1021/2024-12-18_14-15-41/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1021

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1021

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Metadata: no editing disabled hint, while status is running
1 participant