use appsdomain if set in ingress.config

[hihellobolke]

Description

For installations of RHOSP onprem, users can configure ingress to custom domain - appsdomain

The consoleLinks etc assumes the default domain, while rhods-dashboard route's host is set correctly because of route's annotation has openshift.io/host.generated: "true"

How Has This Been Tested?

No.

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• [] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• [] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• [] The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ajaypratap003 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @hihellobolke. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zdtsw]

@hihellobolke Thanks for reporting this and provided a PR for this issue.

I do not think we considered the use case in the past and we will need a bit more investigation as we could have other places skipping this spec filed as well across the downstream product.

[zdtsw]

lgtm
but i would like to see tests on it first

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (incubation@bde4b4e). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/cluster/cluster_config.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             incubation    #1318   +/-   ##
=============================================
  Coverage              ?   19.06%           
=============================================
  Files                 ?       30           
  Lines                 ?     3373           
  Branches              ?        0           
=============================================
  Hits                  ?      643           
  Misses                ?     2661           
  Partials              ?       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[israel-hdez]

@zdtsw I'm happy with the code.

[biswassri]

@hihellobolke Any updates on this PR?