Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use appsdomain if set in ingress.config #1318

Open
wants to merge 1 commit into
base: incubation
Choose a base branch
from
Open

use appsdomain if set in ingress.config #1318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/cluster/cluster_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@
return "", fmt.Errorf("failed fetching cluster's ingress details: %w", err)
}

appsDomain, found, err := unstructured.NestedString(ingress.Object, "spec", "appsDomain")
if found && len(appsDomain) > 0 {
return appsDomain, err
}

Check warning on line 93 in pkg/cluster/cluster_config.go

View check run for this annotation

Codecov / codecov/patch

pkg/cluster/cluster_config.go#L90-L93 

Added lines #L90 - L93 were not covered by tests

domain, found, err := unstructured.NestedString(ingress.Object, "spec", "domain")
if !found {
return "", errors.New("spec.domain not found")
Expand Down
Loading