Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigResources Controller Refactor with Integration Testing for OpenTSDB #313

Open
wants to merge 6 commits into
base: feature/task_cwms_support
Choose a base branch
from

Conversation

zack-rma
Copy link
Collaborator

@zack-rma zack-rma commented Jan 1, 2025

Problem Description

Fixes #235.

Solution

Implements integration testing against OpenTSDB.

how you tested the change

Integration tests included.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma
Copy link
Collaborator Author

zack-rma commented Jan 1, 2025

The current implementation of readConfig returns an empty DTO, which is under investigation

@zack-rma zack-rma changed the title Integration Testing for ConfigResources ConfigResources Controller Refactor with Integration Testing for OpenTSDB Jan 16, 2025
@zack-rma zack-rma self-assigned this Jan 16, 2025
@zack-rma
Copy link
Collaborator Author

Requires Toolkit changes found here: adamkorynta/opendcs#12

Retrieval bugs resolved.

@zack-rma zack-rma marked this pull request as ready for review January 16, 2025 22:42
@zack-rma zack-rma requested a review from rma-rripken January 16, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant