This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
fix: remove periods from project name when release version is present #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
approved these changes
Jan 9, 2024
options.mk
Outdated
| @@ -30,10 +30,10 @@ DEVSTACK_WORKSPACE ?= $(shell pwd)/.. | |||
| # so changing it will give you a separate set of databases. | |||
| # See https://docs.docker.com/compose/reference/envvars/#compose_project_name | |||
| # If OPENEDX_RELAESE is defined, defaults to `devstack-${OPENEDX_RELEASE}`; | |||
| # otherwise, it defaults to `devstack`. | |||
| # otherwise, it defaults to `devstack`. Any periods will be replaced with hyphens to comply with docker project naming rules. | |||
There was a problem hiding this comment.
Nit:
- Consider providing an example with a real openedx release so it stands out more.
- Do we have docs around using devstack for openedx releases?
There was a problem hiding this comment.
- Will fix
- Yes. I am going to make a ticket to remove them, just haven't done that yet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1248
I've completed each of the following or determined they are not applicable: