Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

fix: remove periods from project name when release version is present #1252

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix: remove periods from project name when release version is present #1252

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6f0d6e
fix: remove periods from project name when release version is present
Jan 9, 2024
9490ec3
fixup!: update comment
Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions options.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ DEVSTACK_WORKSPACE ?= $(shell pwd)/..
# so changing it will give you a separate set of databases.
# See https://docs.docker.com/compose/reference/envvars/#compose_project_name
# If OPENEDX_RELAESE is defined, defaults to `devstack-${OPENEDX_RELEASE}`;
# otherwise, it defaults to `devstack`.
# otherwise, it defaults to `devstack`. Any periods will be replaced with hyphens to comply with docker project naming rules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

  1. Consider providing an example with a real openedx release so it stands out more.
  2. Do we have docs around using devstack for openedx releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Will fix
  2. Yes. I am going to make a ticket to remove them, just haven't done that yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 is now #1253

# Be sure to bring down services before changing the value of `COMPOSE_PROJECT_NAME`.
ifdef OPENEDX_RELEASE
COMPOSE_PROJECT_NAME ?= devstack-${OPENEDX_RELEASE}
COMPOSE_PROJECT_NAME ?= devstack-$(echo ${OPENEDX_RELEASE} | tr . -)
else
COMPOSE_PROJECT_NAME ?= devstack
endif
Expand Down