feat: apple-silicon support #920
Conversation
- working mysql image - updated user/grant syntax for mysql8
|
There's a previous effort towards this in #852 that was abandoned after hitting a couple of blockers, it may be useful for reference. |
- redis workaround
Merge branch 'master' into apple-silicon
Merge branch 'master' into apple-silicon
johnnagro
force-pushed
the
apple-silicon
branch
from
67d1ac2
to
d245daa
Compare
- Merge branch 'master' into apple-silicon
docker-compose.yml
Outdated
| @@ -258,7 +258,7 @@ services: | |||
| container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.redis" | |||
| hostname: redis.devstack.edx | |||
| image: redis:2.8 | |||
| command: redis-server --requirepass password | |||
| command: env -i /usr/local/bin/redis-server --requirepass password | |||
There was a problem hiding this comment.
redis 5 shouldn't require this hack if we chose to upgrade
- rename mysql57 assets -> mysql80 to preserve old data - todo: migration pathway for folks who want to keep their old data
| @@ -237,28 +237,28 @@ services: | |||
| volumes: | |||
| - mongo_data:/data/db | |||
|
|
|||
| mysql57: | |||
| mysql80: | |||
There was a problem hiding this comment.
The dev-env working group decided the most reasonable path forward here was to rename MySQL-related docker assets. this avoids data incompatibility and allows existing volumes (with data) to be preserved in the event we want to access that preexisting data.
- adding a backwards compatible mysql hostname alias
| networks: | ||
| default: | ||
| aliases: | ||
| - edx.devstack.mysql80 | ||
| - edx.devstack.mysql57 |
There was a problem hiding this comment.
keeping the old edx.devstack.mysql57 alias provides backwards comparability for projects with local config that point to the old hostname
There was a problem hiding this comment.
Should we put an expiration date on this?
- Merge branch 'master' into apple-silicon
- Merge branch 'master' into apple-silicon
- Merge branch 'master' into apple-silicon
- Merge branch 'master' into apple-silicon
| environment: | ||
| MYSQL_ROOT_PASSWORD: "" | ||
| MYSQL_ALLOW_EMPTY_PASSWORD: "yes" | ||
| image: mysql:5.7 | ||
| image: mysql:8.0.28-oracle |
There was a problem hiding this comment.
curiosity - why the oracle version?
| networks: | ||
| default: | ||
| aliases: | ||
| - edx.devstack.mysql80 | ||
| - edx.devstack.mysql57 |
There was a problem hiding this comment.
Should we put an expiration date on this?
|
Just double checking before I approve: developers who are using devstack right now will not lose any data when they update their devstack from this PR, right? Will they need to do anything else (make dev.pull, I imagine?)? @johnnagro |
|
The PR #968 seems to work and would negate the need for this |
|
We've been able to build/use a cross-platform-compatible Mysql5.7 image via #968 and no longer need this |
Description
Putting together a branch that supports Apple M1 macs. So far it is backwards compatible with Intel macs but reserving the right to make breaking changes.
Unresolved Issues
pngquantversion incompatibilitiesNotes
arm64v8, although we haven't had to specify that anywhere (yet)Changes
Testing
Related Work
I've completed each of the following or determined they are not applicable: