This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 425
feat: apple-silicon support #920
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b46e7c9
feat: apple-silicon support
johnnagro 9f10708
Merge branch 'master' into apple-silicon
johnnagro 005c32b
feat: apple-silicon support
johnnagro aab6457
feat: apple-silicon support
johnnagro d245daa
feat: apple-silicon support
johnnagro 6f271f9
feat: apple-silicon support
johnnagro dca5b1c
chore: Merge branch 'master' into apple-silicon
johnnagro ad73950
feat: apple-silicon support
johnnagro c0b90a6
feat: apple-silicon support
johnnagro fb533bd
feat: apple-silicon support
johnnagro 6abda6e
feat: apple-silicon support
johnnagro dbde522
feat: apple-silicon support
johnnagro 874530c
feat: apple-silicon support
johnnagro 9bf8024
Merge branch 'master' into apple-silicon
f60a317
chore: Updating Python Requirements (#951)
edx-requirements-bot 90e7699
Merge branch 'master' into apple-silicon
johnnagro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -237,22 +237,23 @@ services: | |
volumes: | ||
- mongo_data:/data/db | ||
|
||
mysql57: | ||
mysql80: | ||
command: mysqld --character-set-server=utf8 --collation-server=utf8_general_ci | ||
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.mysql57" | ||
hostname: mysql57.devstack.edx | ||
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.mysql80" | ||
hostname: mysql80.devstack.edx | ||
environment: | ||
MYSQL_ROOT_PASSWORD: "" | ||
MYSQL_ALLOW_EMPTY_PASSWORD: "yes" | ||
image: mysql:5.7 | ||
image: mysql:8.0.28-oracle | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. curiosity - why the oracle version? |
||
networks: | ||
default: | ||
aliases: | ||
- edx.devstack.mysql80 | ||
- edx.devstack.mysql57 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. keeping the old There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we put an expiration date on this? |
||
ports: | ||
- "3506:3306" | ||
volumes: | ||
- mysql57_data:/var/lib/mysql | ||
- mysql80_data:/var/lib/mysql | ||
|
||
redis: | ||
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.redis" | ||
|
@@ -309,13 +310,13 @@ services: | |
depends_on: | ||
- lms | ||
- memcached | ||
- mysql57 | ||
- mysql80 | ||
# Allows attachment to the credentials service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
tty: true | ||
environment: | ||
CACHE_LOCATION: edx.devstack.memcached:11211 | ||
DB_HOST: edx.devstack.mysql57 | ||
DB_HOST: edx.devstack.mysql80 | ||
SOCIAL_AUTH_EDX_OIDC_URL_ROOT: http://edx.devstack.lms:18000/oauth2 | ||
ENABLE_DJANGO_TOOLBAR: 1 | ||
DJANGO_WATCHMAN_TIMEOUT: 30 | ||
|
@@ -334,14 +335,14 @@ services: | |
depends_on: | ||
- elasticsearch710 | ||
- memcached | ||
- mysql57 | ||
- mysql80 | ||
# Allows attachment to the discovery service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
tty: true | ||
environment: | ||
# This next DB_MIGRATION_HOST line can be removed once edx/configuration has been updated with this value for | ||
# a while and most people have had a chance to do a "make pull" to get the latest images. | ||
DB_MIGRATION_HOST: edx.devstack.mysql57 | ||
DB_MIGRATION_HOST: edx.devstack.mysql80 | ||
TEST_ELASTICSEARCH_URL: "edx.devstack.elasticsearch710" | ||
ENABLE_DJANGO_TOOLBAR: 1 | ||
DJANGO_WATCHMAN_TIMEOUT: 30 | ||
|
@@ -363,7 +364,7 @@ services: | |
- discovery | ||
- lms | ||
- memcached | ||
- mysql57 | ||
- mysql80 | ||
# Allows attachment to the ecommerce service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
tty: true | ||
|
@@ -387,7 +388,7 @@ services: | |
- devpi | ||
- elasticsearch710 | ||
- lms | ||
- mysql57 | ||
- mysql80 | ||
image: edxops/notes:${OPENEDX_RELEASE:-latest} | ||
networks: | ||
default: | ||
|
@@ -397,7 +398,7 @@ services: | |
- "18120:18120" | ||
environment: | ||
DB_ENGINE: "django.db.backends.mysql" | ||
DB_HOST: "edx.devstack.mysql57" | ||
DB_HOST: "edx.devstack.mysql80" | ||
DB_NAME: "notes" | ||
DB_PASSWORD: "password" | ||
DB_PORT: "3306" | ||
|
@@ -437,7 +438,7 @@ services: | |
- forum | ||
- memcached | ||
- mongo | ||
- mysql57 | ||
- mysql80 | ||
- opensearch12 | ||
# Allows attachment to the LMS service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
|
@@ -469,14 +470,14 @@ services: | |
hostname: insights.devstack.edx | ||
depends_on: | ||
- analyticsapi | ||
- mysql57 | ||
- mysql80 | ||
- lms | ||
- memcached | ||
# Allows attachment to the insights service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
tty: true | ||
environment: | ||
DB_HOST: edx.devstack.mysql57 | ||
DB_HOST: edx.devstack.mysql80 | ||
DB_NAME: dashboard | ||
DB_PORT: 3306 | ||
DB_USER: analytics001 | ||
|
@@ -498,13 +499,13 @@ services: | |
container_name: edx.devstack.analyticsapi | ||
hostname: analyticsapi | ||
depends_on: | ||
- mysql57 | ||
- mysql80 | ||
- elasticsearch710 | ||
command: bash -c 'source /edx/app/analytics_api/analytics_api_env && while true; do python /edx/app/analytics_api/analytics_api/manage.py runserver 0.0.0.0:19001 --settings analyticsdataserver.settings.devstack; sleep 2; done' | ||
stdin_open: true | ||
tty: true | ||
environment: | ||
DB_HOST: edx.devstack.mysql57 | ||
DB_HOST: edx.devstack.mysql80 | ||
DB_PORT: 3306 | ||
DB_USER: analytics001 | ||
DB_PASSWORD: password | ||
|
@@ -521,15 +522,15 @@ services: | |
depends_on: | ||
- discovery | ||
- lms | ||
- mysql57 | ||
- mysql80 | ||
- memcached | ||
- redis | ||
- registrar-worker | ||
# Allows attachment to the registrar service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
tty: true | ||
environment: | ||
DB_HOST: edx.devstack.mysql57 | ||
DB_HOST: edx.devstack.mysql80 | ||
DB_NAME: registrar | ||
DB_PORT: 3306 | ||
DB_USER: registrar001 | ||
|
@@ -559,12 +560,12 @@ services: | |
hostname: registrar-worker.devstack.edx | ||
depends_on: | ||
- lms | ||
- mysql57 | ||
- mysql80 | ||
- redis | ||
stdin_open: true | ||
tty: true | ||
environment: | ||
DB_HOST: edx.devstack.mysql57 | ||
DB_HOST: edx.devstack.mysql80 | ||
DB_NAME: registrar | ||
DB_PORT: 3306 | ||
DB_USER: registrar001 | ||
|
@@ -597,7 +598,7 @@ services: | |
- lms | ||
- memcached | ||
- mongo | ||
- mysql57 | ||
- mysql80 | ||
- opensearch12 | ||
# Allows attachment to the Studio service using 'docker attach <containerID>'. | ||
stdin_open: true | ||
|
@@ -630,7 +631,7 @@ services: | |
volumes: | ||
- ${DEVSTACK_WORKSPACE}/xqueue:/edx/app/xqueue/xqueue | ||
depends_on: | ||
- mysql57 | ||
- mysql80 | ||
networks: | ||
default: | ||
aliases: | ||
|
@@ -645,7 +646,7 @@ services: | |
volumes: | ||
- ${DEVSTACK_WORKSPACE}/xqueue:/edx/app/xqueue/xqueue | ||
depends_on: | ||
- mysql57 | ||
- mysql80 | ||
networks: | ||
default: | ||
aliases: | ||
|
@@ -837,4 +838,4 @@ volumes: | |
elasticsearch710_data: | ||
mongo_data: | ||
opensearch12_data: | ||
mysql57_data: | ||
mysql80_data: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev-env working group decided the most reasonable path forward here was to rename MySQL-related docker assets. this avoids data incompatibility and allows existing volumes (with data) to be preserved in the event we want to access that preexisting data.