-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0049] feat: Remove taxonomy export id prompt #955
[FC-0049] feat: Remove taxonomy export id prompt #955
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
594520a
to
8cca048
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
==========================================
- Coverage 92.10% 92.10% -0.01%
==========================================
Files 634 634
Lines 11091 11090 -1
Branches 2358 2358
==========================================
- Hits 10215 10214 -1
Misses 847 847
Partials 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yusuf-musleh Looks good 👍 I've seen that this PR depends on openedx/openedx-learning#182 to work. You will need to create a PR on edx-platform to update openedx-learning after openedx/edx-platform#34490. Another thing I have thought about is updating it at openedx/edx-platform#34490, but there would be 3 PRs that would have to be merged at the same time. CC @bradenmacdonald
- I tested this: I followed the testing instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
- Includes documentation
@ChrisChV I think you should just update openedx/edx-platform#34490 to use 0.9.2, and we'll merge it at the same time as #939 . We can merge this PR later - it won't break anything to update the other PRs without merging this one. |
Ok, I will follow this plan 👍 I bump the version in openedx/edx-platform#34490 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This good to merge once the related PR is merged.
@xitij2000 Related PR is merged. |
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Removes the prompt to enter an export ID when importing a taxonomy. It will be automatically generated by the system.
Supporting information
Related Tickets:
Testing instructions
new_studio_mfe.use_tagging_taxonomy_list_page
Private-ref: FAL-3706