Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0049] feat: Remove taxonomy export id prompt #955

Merged

Conversation

yusuf-musleh
Copy link
Member

@yusuf-musleh yusuf-musleh commented Apr 18, 2024

Description

Removes the prompt to enter an export ID when importing a taxonomy. It will be automatically generated by the system.

Supporting information

Related Tickets:

Testing instructions

  1. Run this branch in your local tutor/devstack
  2. Make sure to run [FC-0049] feat: Auto generate taxonomy export ID if not provided openedx-learning#182 locally as well
  3. Make sure you have taxonomies list page enabled: new_studio_mfe.use_tagging_taxonomy_list_page
  4. Make sure you have some sample taxonomies loaded: https://github.com/open-craft/taxonomy-sample-data/
  5. Navigate to the taxonomies list page
  6. Export a taxonomy so you can use it in the following steps
  7. Import the taxonomy you exported, and confirm that it doesn't ask you to set an export id and it successfully imports it
  8. Click on the newly import taxonomy and confirm that an export id has been generated for it.

Private-ref: FAL-3706

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 18, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 18, 2024

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/remove-export-id-prompt branch from 594520a to 8cca048 Compare April 18, 2024 12:58
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (422a5db) to head (8cca048).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   92.10%   92.10%   -0.01%     
==========================================
  Files         634      634              
  Lines       11091    11090       -1     
  Branches     2358     2358              
==========================================
- Hits        10215    10214       -1     
  Misses        847      847              
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh changed the title feat: Remove taxonomy export id prompt [FC-0049] feat: Remove taxonomy export id prompt Apr 18, 2024
@yusuf-musleh yusuf-musleh marked this pull request as ready for review April 18, 2024 14:52
@yusuf-musleh yusuf-musleh requested a review from a team as a code owner April 18, 2024 14:52
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good 👍 I've seen that this PR depends on openedx/openedx-learning#182 to work. You will need to create a PR on edx-platform to update openedx-learning after openedx/edx-platform#34490. Another thing I have thought about is updating it at openedx/edx-platform#34490, but there would be 3 PRs that would have to be merged at the same time. CC @bradenmacdonald

  • I tested this: I followed the testing instructions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

@bradenmacdonald
Copy link
Contributor

@ChrisChV I think you should just update openedx/edx-platform#34490 to use 0.9.2, and we'll merge it at the same time as #939 .

We can merge this PR later - it won't break anything to update the other PRs without merging this one.

@ChrisChV
Copy link
Contributor

I think you should just update openedx/edx-platform#34490 to use 0.9.2, and we'll merge it at the same time as #939 .

Ok, I will follow this plan 👍 I bump the version in openedx/edx-platform#34490

Copy link
Contributor

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This good to merge once the related PR is merged.

@bradenmacdonald
Copy link
Contributor

@xitij2000 Related PR is merged.

@xitij2000 xitij2000 merged commit 4146fa6 into openedx:master Apr 25, 2024
6 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the yusuf-musleh/remove-export-id-prompt branch April 25, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Export ids should be auto-generated
5 participants