[FC-0049] feat: Auto generate taxonomy export ID if not provided #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
yusuf-musleh
force-pushed
the
yusuf-musleh/generate-taxonomy-export-id-if-not-provided
branch
2 times, most recently
from
d5039e9 to
48d4ad9
Compare
yusuf-musleh
force-pushed
the
yusuf-musleh/generate-taxonomy-export-id-if-not-provided
branch
from
48d4ad9 to
b64e8ee
Compare
yusuf-musleh
changed the title
ChrisChV
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
@yusuf-musleh Looks good! 👍
- I tested this: I followed the testing instructions of [FC-0049] feat: Remove taxonomy export id prompt frontend-app-authoring#955
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
- Includes documentation
bradenmacdonald
approved these changes
Apr 18, 2024
|
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
bradenmacdonald
deleted the
yusuf-musleh/generate-taxonomy-export-id-if-not-provided
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the import taxonomy view to allow users to import a taxonomy without specifying an export id. If it is provided it will use it otherwise, it will generate one.
Supporting information
Related Tickets:
Testing instructions
Private-ref: FAL-3706