Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0036] feat: Update ObjectTagView #180

Merged

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Apr 8, 2024

Description

Updates ObjectTagView Put request to update multiple taxonomies in one request

Supporting information

Testing instructions

@ChrisChV ChrisChV marked this pull request as draft April 8, 2024 21:06
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 8, 2024

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV changed the title feat: Update ObjectTagView [FC-0036] feat: Update ObjectTagView Apr 8, 2024
@ChrisChV ChrisChV marked this pull request as ready for review April 10, 2024 19:15
@bradenmacdonald
Copy link
Contributor

@ChrisChV Is this ready for review?

@ChrisChV
Copy link
Contributor Author

@bradenmacdonald Yes, It's ready 👍

@bradenmacdonald
Copy link
Contributor

@ChrisChV It LGTM. I'll let @yusuf-musleh test it first before I merge it though.

Once we merge this and update edx-platform, won't it break tagging until we've updated course-authoring too though? It may have been better to implement this in a backwards compatible way. But I guess it's fine, as long as we coordinate the merges all at the same time.

@ChrisChV
Copy link
Contributor Author

Once we merge this and update edx-platform, won't it break tagging until we've updated course-authoring too though?

Yes, It is necessary to merge openedx/frontend-app-authoring#939 and openedx/edx-platform#34490 at the same time

Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Works great and looks good to me too! Just a small nit/question.

openedx_tagging/core/tagging/rest_api/v1/views.py Outdated Show resolved Hide resolved
@bradenmacdonald bradenmacdonald merged commit 797618d into openedx:main Apr 15, 2024
12 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the chris/FAL-3645-refined-drawer branch April 15, 2024 17:38
@ChrisChV
Copy link
Contributor Author

@bradenmacdonald could you create a new tag with the version 0.9.1?

@bradenmacdonald
Copy link
Contributor

@ChrisChV Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants