Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump openedx-learning to support tagging with multiple taxonomies at once [FC-0036] #34490

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Bump openedx-learning to support tagging with multiple taxonomies at once [FC-0036] #34490

merged 7 commits into from
Apr 25, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Apr 8, 2024 •
edited
Loading

Description

Updates openedx_learning version

Supporting information

Testing instructions

Other information

@ChrisChV ChrisChV marked this pull request as draft April 8, 2024 21:31
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 8, 2024 •
edited
Loading

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV changed the title chore: Use openedx_learning from opencraft repo [FC-0036] chore: Use openedx_learning from opencraft repo Apr 8, 2024
This was referenced Apr 10, 2024
Merged
Merged
@ChrisChV ChrisChV marked this pull request as ready for review April 11, 2024 16:31
@ChrisChV
Copy link
Contributor Author

Update: It is necessary to merge this at the same time of: openedx/frontend-app-authoring#939

yusuf-musleh
yusuf-musleh approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

This was referenced Apr 17, 2024
Closed
Merged
@bradenmacdonald bradenmacdonald changed the title [FC-0036] chore: Use openedx_learning from opencraft repo Bump openedx-learning to support tagging with multiple taxonomies at once [FC-0036] Apr 18, 2024
@feanil feanil linked an issue Apr 22, 2024 that may be closed by this pull request
Test openedx-learning on Python 3.11 openedx/openedx-learning#174
Closed
6 tasks
bradenmacdonald
bradenmacdonald approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We need to merge openedx/frontend-app-authoring#939 soon after merging this, so waiting until that one is approved and ready to merge.

@xitij2000
Copy link
Contributor

LGTM

We need to merge openedx/frontend-app-course-authoring#939 soon after merging this, so waiting until that one is approved and ready to merge.

That PR is approved. Do ping me when this is merged.

@bradenmacdonald bradenmacdonald merged commit a33165a into openedx:master Apr 25, 2024
67 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/FAL-3645-refined-tag-drawer branch April 25, 2024 17:44
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@ChrisChV ChrisChV mentioned this pull request Apr 25, 2024
Merged
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@pomegranited pomegranited mentioned this pull request May 5, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusuf-musleh yusuf-musleh yusuf-musleh approved these changes

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test openedx-learning on Python 3.11
6 participants
@ChrisChV @openedx-webhooks @xitij2000 @edx-pipeline-bot @bradenmacdonald @yusuf-musleh