chore: install psc-package via a NPM script

[PenghaiZhang]

Checklist

• the [contributor license agreement][] is signed
• commit message follows [commit guidelines][]
• tests are included
• screenshots are included showing significant UI changes
• documentation is changed or added

Description of change

With NPM 7 psc-package is not installed properly. So we created a new NPM script which will downloaded the package and use it.

This issue was originally found in renovate PRs (e.g. #3380 ) which failed to update package-lock.json.

[edalex-ian]

Looks pretty good, may just want to tweak description to also mention this was triggered due to issues with renovate.

[edalex-ian]

Cool, so just the one comment around the left over GHA step, and still need to pin those deps.

[PenghaiZhang]

Looks pretty good, may just want to tweak description to also mention this was triggered due to issues with renovate.

Can I mention this was triggered due to issues with renovate in the merge commit ?

[edalex-ian]

Good to have both places. At least if you just duck up and edit the merge request description it'll be there nice and loud for if we need to reference back to it. And then if you put it in the merge commit it will be nicely there for future prosperity on the quite.

[edalex-ian]

LGTM! 👍

[PenghaiZhang]

Good to have both places. At least if you just duck up and edit the merge request description it'll be there nice and loud for if we need to reference back to it. And then if you put it in the merge commit it will be nicely there for future prosperity on the quite.

Cool. I have updated the PR description.

[PenghaiZhang]

Ah GHA is still using NPM 6...

[PenghaiZhang]

Failed on pulp build...

> pulp build

* Building project in /home/penghai/Edalex/forks/openEQUELLA/autotest/IntegTester/ps
* ERROR: `psc-package` executable not found.

[edalex-ian]

Good job @PenghaiZhang ! Looks like you've pretty well won. 🎉

Just need to remove that bit of redundant code in install.js and then you should be GTG. 👍

[HonkingGoose]

Did you know that setup-node comes with caching now?

Suggested change

	node-version: "${{ steps.nvm.outputs.NVMRC }}"
	node-version: "${{ steps.nvm.outputs.NVMRC }}"
	cache: npm

Read the readme and learn more here: https://github.com/actions/setup-node#caching-packages-dependencies.

By the way setup-java comes with caching as well, but I don't know much about Java, so won't apply any suggestions here.

https://github.com/actions/setup-java#caching-packages-dependencies

Also check if the version of setup-java you're using comes with the caching capability before you turn it on for Java.

[edalex-ian]

That's a nice new feature. Thanks for letting us know. We'll have a look and see what we might be able to refactor, because the build definition sure is long.

[HonkingGoose]

@edalex-ian Do you want me to make an issue with the same text? That way I'm not blocking this PR, and you can track the issue that way, and follow up when you have time to work on it.

[edalex-ian]

That'd be great thanks @HonkingGoose. 👍

I'll go and merge this in the meantime. 😉

[HonkingGoose]

See issue #3390 for the "feature request".