For toppings avoid issues with backslashes

[signedav]

On windows backslashes where created with topping exporter file paths.
This leaded to issues when the relative path has been attached to an url.

The IliDataCache.download_file now:

• replaces the backslashes with slashes on URL
• normalizes the path to the current system

Still ili2db does not that.

The IliToppingMaker creating those paths is now storing everything with backslashes as well, nerveless if it's an url or a file path (because it cannot know that).

Windows can handel slashes in the path as well AFAIK, what means it's more stable to have slashes.

[gacarrillor]

Do you plan to adjust the topping exporter URL/path generation as well? For instance, replacing the os module by pathlib?

[signedav]

In the "modelbaker" part ilitoppingmaker.Target I just replaced the backslashes. Are there better ways to do it with pathlib maybe I've overseen that, but I could not find kind of an urinormalizer.

The library toppingmaker I leave like it is. Because people might use it primarily locally.

[gacarrillor]

In the "modelbaker" part ilitoppingmaker.Target I just replaced the backslashes. Are there better ways to do it with pathlib maybe I've overseen that, but I could not find kind of an urinormalizer.

As far as I know, you'd need to tell pathlib you've got a pure Windows path and then it can normalize it. Something like:

p = pathlib.PureWindowsPath("my\\path")
p.as_posix()

or

p = pathlib.PureWindowsPath(r"my\path")
p.as_posix()

[signedav]

But the question is in the end how you write it to the yaml (or the ilidata file) and there you have to decide if it's slash or backslash or am I not getting something?

[gacarrillor]

But the question is in the end how you write it to the yaml (or the ilidata file) and there you have to decide if it's slash or backslash or am I not getting something?

I think I'm missing something since the beginning :). That's why I wrote the question.
If you can standardize the way paths get written into the yaml or ilidata files, that would be the way to go in my opinion. Probably I'm missing some scenarios, because I thought that choosing forward slashes there would always be preferred (or even enforced).

[signedav]

ah no, you are right. I got confused by the PureWindowsPath and I thought it creates a windows path out of it (what is the opposite of what I wanted). But it does exactly what we need. Thanks.