Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For toppings avoid issues with backslashes #120

Merged
merged 2 commits into from
Nov 15, 2024
Merged

For toppings avoid issues with backslashes #120

merged 2 commits into from
Nov 15, 2024

Commits on Nov 14, 2024

  1. On windows backslashes where created with topping exporter file paths. 

    This leaded to issues when the relative path has been attached to an url.

The IliDataCache.download_file now:
- replaces the backslashes with slashes on URL
- normalizes the path to the current system

Still ili2db does not that.

The IliToppingMaker creating those paths is now storing everything with backslashes as well, nerveless if it's an url or a file path (because it cannot know that).

Windows can handel slashes in the path as well AFAIK, what means it's more stable to have slashes.
    @signedav
    signedav committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    04f4593 View commit details
    Browse the repository at this point in the history

  2. use pathlib to noramlize paths (means having only / instead of \)

    @signedav
    signedav committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    21f64d6 View commit details
    Browse the repository at this point in the history