-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jasper SLEC script changes #1003
Conversation
Updated jasper SLEC script for parameters usage. Added assumption files and bind file scripts/slec/cadence folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Are the
.DS_Store
files required as inputs to Jasper, or are they tool artefacts? If they are artefacts, they should not be added to the repository. - Please add the appropriate license headers to the clear-text files. The following "two liner" is sufficient:
// Copyright 2024 <your-organization>
// SPDX-License-Identifier: Apache-2.0 WITH SHL-2.1
Added license headers
Hi @mret55, thanks for this PR. I have requested a couple of changes. Also, the Eclipse ECA check is failing, but I checked and Eclipse reports that |
Hi @mret55, the Eclipse ECA check is now passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found assume files but no file containing row4 assertion.
Once added, it should be added to cv32e40p_tb_src.flist.
…. Uncommented the row4 trigger_match_i assertion from controller_assert file
I have uncommented the row4 assertion from cv32e40p/scripts/formal/src/cv32e40p_controller_assert.sv. |
Hi @pascalgouedo, |
Are data_assert2 and insn_assert2 really useful as they are duplicates of data_assert and insn_assert? |
Hi @pascalgouedo, Also, these are used for 2 different applications. One in cv32e40p/scripts/formal/ is for FPV (property verification), while one in cv32e40p/scripts/slec/cadence/tb_src is for SLEC. I will need to run tweak run.sh for those packages, remove existing files and rerun jasper again if we were to consolidate the files. Not sure, if I will be able to get around to doing that quick. In its existing setup (as per this pull request), it works fine. |
Approving and merging as per @pascalgouedo request. (Note that I have no way to test this from my current location.) |
Updated jasper SLEC script for parameters usage. Added assumption files and bind file scripts/slec/cadence folder.