Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding obi2ahb gasket #160

Merged
merged 2 commits into from
Dec 12, 2023
Merged

adding obi2ahb gasket #160

merged 2 commits into from
Dec 12, 2023

Conversation

LeeHoff
Copy link

@LeeHoff LeeHoff commented Sep 29, 2023

source file obi2ahb_adapter.sv and initial design spec "OBI2AHMB_Adapter Design Spec.pdf"

@MikeOpenHWGroup
Copy link
Member

Thanks for this @LeeHoff! Can we get a version of the documentation with an Apache/Solderpad license header added?

@christian-herber-nxp
Copy link

I can't really be a reviewer for the RTL. However, I would question if this should be in a folder called example. This suggests to me at most TRL2-3. In my understanding, the gasket should be at the same quality level as the rest.

@LeeHoff LeeHoff reopened this Oct 10, 2023
@LeeHoff
Copy link
Author

LeeHoff commented Oct 10, 2023

Correcting the copywrite string.

@MikeOpenHWGroup
Copy link
Member

LGTM @LeeHoff, thanks for the update. I have approved this PR, so legally it is good-to-merge, but I will defer to either yourself or @davideschiavone to execute. Thanks for this contribution!

@davideschiavone
Copy link

@LeeHoff , @christian-herber-nxp , @joecircello , before digging into the RTL review, a question/suggestion from my side, wouldn't it be better to have this in a separate repository so that it can be used by any OBI master?

@MikeOpenHWGroup
Copy link
Member

wouldn't it be better to have this in a separate repository so that it can be used by any OBI master?

It was suggested that we should get this specific component into an OpenHW repo first and worry about the creation of a library repo at a later date.

While one could argue that we should have a repo for a library of reuseable RTL components, we currently do not and we can always move this component at a later date.

@davideschiavone
Copy link

I think this is a good occasion to make one :) meanwhile I will add my comments

examples/obi2ahb/obi2ahbm_adapter.sv Outdated Show resolved Hide resolved
examples/obi2ahb/obi2ahbm_adapter.sv Outdated Show resolved Hide resolved
examples/obi2ahb/obi2ahbm_adapter.sv Outdated Show resolved Hide resolved
examples/obi2ahb/obi2ahbm_adapter.sv Outdated Show resolved Hide resolved
examples/obi2ahb/obi2ahbm_adapter.sv Show resolved Hide resolved
examples/obi2ahb/obi2ahbm_adapter.sv Outdated Show resolved Hide resolved
examples/obi2ahb/obi2ahbm_adapter.sv Show resolved Hide resolved
Signed-off-by: Lee Hoff <[email protected]>
@davideschiavone davideschiavone merged commit 13c86e6 into openhwgroup:main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants