-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding obi2ahb gasket #160
Conversation
Thanks for this @LeeHoff! Can we get a version of the documentation with an Apache/Solderpad license header added? |
I can't really be a reviewer for the RTL. However, I would question if this should be in a folder called example. This suggests to me at most TRL2-3. In my understanding, the gasket should be at the same quality level as the rest. |
Signed-off-by: Lee Hoff <[email protected]>
Correcting the copywrite string. |
LGTM @LeeHoff, thanks for the update. I have approved this PR, so legally it is good-to-merge, but I will defer to either yourself or @davideschiavone to execute. Thanks for this contribution! |
@LeeHoff , @christian-herber-nxp , @joecircello , before digging into the RTL review, a question/suggestion from my side, wouldn't it be better to have this in a separate repository so that it can be used by any OBI master? |
It was suggested that we should get this specific component into an OpenHW repo first and worry about the creation of a library repo at a later date. While one could argue that we should have a repo for a library of reuseable RTL components, we currently do not and we can always move this component at a later date. |
I think this is a good occasion to make one :) meanwhile I will add my comments |
Signed-off-by: Lee Hoff <[email protected]>
source file obi2ahb_adapter.sv and initial design spec "OBI2AHMB_Adapter Design Spec.pdf"