Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporter record management #65

Merged
merged 23 commits into from
Jun 4, 2024
Merged

Supporter record management #65

merged 23 commits into from
Jun 4, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented May 8, 2024 •
edited
Loading

This closes #63 and closes #54 as well as completing some necessary yak shaving:

  • Simplifies the types of bands into a choice field called "category". Bands can now be base, calculated, or special.
  • Updates the logic and utils methods to use this field
  • Updates the tests in line with logic and utils, and while we're at it, to be more readable and maintainable
  • Starts work on As a press manager I want to manage bands from year to year #64 in the models and utils (e.g. prospective_band and get_total_revenue)

TIP! You can quickly get up and running with some sample data by running the management
command install_example_supporter_data.

@joemull joemull self-assigned this May 8, 2024
@joemull joemull mentioned this pull request May 21, 2024
Merged
@joemull joemull marked this pull request as ready for review May 21, 2024 16:41
@joemull joemull requested a review from mauromsl May 21, 2024 16:43
@joemull joemull assigned mauromsl and unassigned joemull May 21, 2024
@joemull joemull mentioned this pull request May 21, 2024
Merged
mauromsl
mauromsl requested changes May 24, 2024
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this was a lot of work @joemull !

I've added a few comments and questions inline, but overall the new features are nice to have.

admin.py Outdated Show resolved Hide resolved
forms.py Outdated Show resolved Hide resolved
forms.py Outdated Show resolved Hide resolved
forms.py Outdated Show resolved Hide resolved
models.py Outdated Show resolved Hide resolved
templates/consortial_billing/supporter_list.html Outdated Show resolved Hide resolved
templates/consortial_billing/supporter_list_item.html Outdated Show resolved Hide resolved
tests/test_forms.py Show resolved Hide resolved
views.py Outdated Show resolved Hide resolved
views.py Outdated Show resolved Hide resolved
@mauromsl mauromsl assigned joemull and ajrbyers and unassigned mauromsl and ajrbyers May 24, 2024
@joemull joemull requested a review from mauromsl May 31, 2024 07:36
@joemull joemull assigned mauromsl and unassigned joemull May 31, 2024
@mauromsl mauromsl merged commit 233b926 into master Jun 4, 2024
@mauromsl mauromsl mentioned this pull request Jun 4, 2024
Merged
@joemull joemull added this to the Biller UX milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees

@mauromsl mauromsl

Labels
None yet
Projects
None yet
Milestone
Biller UX
Development

Successfully merging this pull request may close these issues.

Management of supporter records Allow billing agents to submit supporter details on behalf of someone else
3 participants
@joemull @mauromsl @ajrbyers