Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIE-2] Skeleton code for client registry search flow #11

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Conversation

samuelmale
Copy link
Member

This PR was authored by @pmanko2 as a base implementation for ticket HIE-2 (see original PR). The work is mostly WIP and is meant to set the stage for the next steps, which include:

  • Consolidate the API
    • Expand on the patient search API in the CRService
    • Support CRUD operations in the CRService
    • Test coverage
  • Support for other authentication schemes eg. OAuth2, Tokens etc.
  • Make Patient interceptor configurable
  • Implement RESTful API
  • Exception Handling

pmanko2 and others added 6 commits March 20, 2024 00:19
[HIE-2] define ihe-pix operation and start implementation of getCRPatient

[HIE-2] adding config options for default system and get patient endpoint

[HIE-2] drop format param and change targetSystems to OR

[HIE-2] move targetSystem param logic to controller

[HIE-2] change to OperationParam in getCRPatient provider method

cleanup, adding comments, refactoring Patient parsing
@samuelmale
Copy link
Member Author

samuelmale commented Mar 19, 2024

I've tested this out locally with: OpenMRS + OpenHIM + OpenCR + HAPI FHIR Store setup and it works. Note that I've only tested the Interceptor.

That being said, let's have this merged as groundwork for the next tasks.

cc: @pmanko2 @pmanko @reagan-meant @smallgod

Comment on lines +107 to +111
switch (ClientRegistryTransactionType.valueOf(transactionMethodGlobalProperty)) {
case FHIR:
return fhirPatientService;
case HL7:
throw new IllegalArgumentException("HL7 transaction type is currently unsupported");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to support HL7 or other formats in the future? If not, can we just simply support FHIR? cc: @pmanko @smallgod @ebambo

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for FHIR only as any other transformation will reside outside of this module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, gonna file a ticket to address this.

@samuelmale samuelmale merged commit cdd2597 into main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants