Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIE-2] Skeleton code for client registry search flow #5

Closed
wants to merge 5 commits into from

Conversation

pmanko2
Copy link
Collaborator

@pmanko2 pmanko2 commented Jan 21, 2023

wip


@Search
public List<CRPatient> searchClientRegistryPatients(
@OptionalParam(name = Patient.SP_NAME) StringAndListParam name,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave this unimplemented for now, will implement in separate ticket

* the client registry
* @throws IllegalArgumentException if defined transaction type is unsupported
*/
public CRPatientService getPatientService() throws IllegalArgumentException {
Copy link
Collaborator Author

@pmanko2 pmanko2 Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only needs to be determined once on module startup (and on property changed/deleted), maybe we move the logic into ClientRegistryActivator ?

[HIE-2] define ihe-pix operation and start implementation of getCRPatient

[HIE-2] adding config options for default system and get patient endpoint

[HIE-2] drop format param and change targetSystems to OR

[HIE-2] move targetSystem param logic to controller

[HIE-2] change to OperationParam in getCRPatient provider method

cleanup, adding comments, refactoring Patient parsing
@pmanko2 pmanko2 marked this pull request as ready for review February 12, 2023 19:37
@samuelmale
Copy link
Member

Closing PR, moved to #11

@samuelmale samuelmale closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants