Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: Edits to property titles and descriptions plus codelists, closes #480 #623

Merged
merged 10 commits into from
Apr 10, 2024

Conversation

kd-ods
Copy link
Collaborator

@kd-ods kd-ods commented Apr 3, 2024

Overview

  • What does this pull request do?

Brings the schema descriptions in line with the style guide.

Deals with some specific issues noted re descriptions (#603 #618).

  • How can a reviewer test or examine your changes?

Make sure they're familiar with the Style guide. Read through all the edits and suggest changes.

  • Who is best placed to review it?

@kathryn-ods

Closes #480 #603 #618

Translations

Documentation & Release

@kd-ods kd-ods requested a review from kathryn-ods April 4, 2024 12:20
@kd-ods kd-ods marked this pull request as ready for review April 4, 2024 12:21
@kd-ods kd-ods mentioned this pull request Apr 9, 2024
7 tasks
schema/components.json Outdated Show resolved Hide resolved
schema/statement.json Outdated Show resolved Hide resolved
schema/statement.json Outdated Show resolved Hide resolved
Copy link
Contributor

@kathryn-ods kathryn-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see line comments

@kd-ods
Copy link
Collaborator Author

kd-ods commented Apr 9, 2024

Huge thanks for the review, @kathryn-ods . I've either made the suggested edit and resolved the associated comment, or left a comment explaining my thinking. Requesting re-review now & hopefully we can merge this tomorrow.

@kd-ods kd-ods requested a review from kathryn-ods April 9, 2024 17:13
@kd-ods kd-ods merged commit f2f28f8 into main Apr 10, 2024
2 checks passed
@kd-ods kd-ods deleted the 480-schema-descriptions branch April 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit of schema and codelist descriptions for v0.4 release
2 participants