Fix inconsistent i18n key names in workspace and examples #8483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
AMoo-Miki
approved these changes
Oct 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8483 +/- ##
=======================================
Coverage 60.93% 60.93%
=======================================
Files 3760 3760
Lines 89310 89310
Branches 13970 13970
=======================================
Hits 54423 54423
Misses 31492 31492
Partials 3395 3395
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raintygao
approved these changes
Oct 4, 2024
zhyuanqi
approved these changes
Oct 4, 2024
AMoo-Miki
added
i18n
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Fix i18n keys start with workspaces Signed-off-by: Lin Wang <[email protected]> * Update key to uiActionsExplorer.appTitle Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8483 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 17ec426) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 4, 2024
) * Fix i18n keys start with workspaces * Update key to uiActionsExplorer.appTitle * Changeset file for PR #8483 created/updated --------- (cherry picked from commit 17ec426) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for updating inconsistent i18n key names in workspace plugin and examples. These keys should start with "workspace" instead of "workspaces" according #8423
Changelog
Check List
yarn test:jestyarn test:jest_integration