Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent i18n key names in workspace and examples #8483

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Fix inconsistent i18n key names in workspace and examples #8483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
220bbc2
Fix i18n keys start with workspaces
wanglam Oct 4, 2024
d7582be
Update key to uiActionsExplorer.appTitle
wanglam Oct 4, 2024
5dce18e
Changeset file for PR #8483 created/updated
opensearch-changeset-bot[bot] Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8483.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Fix inconsistent i18n key names in workspace and examples ([#8483](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8483))
2 changes: 1 addition & 1 deletion examples/ui_actions_explorer/public/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const ActionsExplorer = () => {
<EuiTitle size="l">
<h1>
<FormattedMessage
id="uiAsctionsExample.appTitle"
id="uiActionsExplorer.appTitle"
defaultMessage="{name}"
values={{ name: 'UI Actions' }}
/>
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/workspace/public/components/workspace_form/select_data_source_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,15 @@ export const SelectDataSourcePanel = ({
title={
<EuiText size="s">
<h3>
{i18n.translate('workspaces.forms.selectDataSourcePanel.emptyTableTitle', {
{i18n.translate('workspace.forms.selectDataSourcePanel.emptyTableTitle', {
defaultMessage: 'Associated data sources will appear here',
})}
</h3>
</EuiText>
}
body={
<EuiText size="s">
{i18n.translate('workspaces.forms.selectDataSourcePanel.emptyTableDescription', {
{i18n.translate('workspace.forms.selectDataSourcePanel.emptyTableDescription', {
defaultMessage: 'At least one data source is required to create a workspace.',
})}
</EuiText>
Expand Down
Loading