Fixing issues caused by 3.0 version bumping #696
Conversation
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
opensearch-trigger-bot
bot
added
backport 2.x
infra
Signed-off-by: Jackie Han <[email protected]>
…ion 3.0.0 Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
Signed-off-by: Jackie Han <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
============================================
+ Coverage 79.03% 79.05% +0.01%
Complexity 4241 4241
============================================
Files 301 301
Lines 17871 17872 +1
Branches 1897 1897
============================================
+ Hits 14125 14129 +4
+ Misses 2841 2838 -3
Partials 905 905
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jackie Han <[email protected]>
| @@ -136,7 +136,7 @@ configurations.all { | |||
| force "joda-time:joda-time:${versions.joda}" | |||
| force "com.fasterxml.jackson.core:jackson-core:2.13.4" | |||
| force "commons-logging:commons-logging:${versions.commonslogging}" | |||
| force "org.apache.httpcomponents:httpcore:${versions.httpcore}" | |||
| force "org.apache.httpcomponents:httpcore5:${versions.httpcore5}" | |||
There was a problem hiding this comment.
Could we possible just remove this force? and just inherit it as is from opensearch core?
There was a problem hiding this comment.
do you know what's the initial reason of adding this force instead of inheriting it from opensearch core?
There was a problem hiding this comment.
Not sure, seems to be with our initial set up of AD. Usually from my understanding its used if we need a specific version of a dependency that doesn't align with core so we force it to be something else. I believe though since we aren't in need of anything specific we should be able to remove this line and build/testing should be fine.
There was a problem hiding this comment.
Before doing that I would confirm with @ylwu-amzn or @kaituo on the reasoning. When that's figured out, if it's still needed, we should add a clarifying comment above.
|
Can you link the related changes in core here for more context? For example, not sure of the reasoning of the new apache dependencies |
Signed-off-by: Jackie Han <[email protected]>
Updated the description. |
Description
Issues Resolved
opensearch-project/opensearch-plugins#142
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.