Support MDS on workflows and workflow_detail pages

[saimedhi]

Description

• Added support for using MDS on workflows and workflow_detail pages
• Update all route path to make it accept dataSourceId when it has truthy value

Issues Resolved

closes #228

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[saimedhi]

Recording.5.mp4

[jackiehanyang]

Could you mark the PR as a draft until you have completed the end-to-end testing? It includes:

• Turning on/off these two feature flags to ensure backward compatibility works fine.

# Set the value of this setting to true to enable multiple data source feature.
#data_source.enabled: false
# Set the value of this setting to true to hide local cluster in data source feature.
#data_source.hideLocalCluster: false

• Switching between two remote data source clusters to ensure workflow-related data and data source IDs are shown correctly (in url, breadcrumbs.. any possible places).
• Proving that the workflow you created when remote data source A was connected can also be found in cluster A.
• Since we don't have tests here, try to click on all possible buttons to test all functionalities. For example, the delete and link button on the Manage Workflows page.
• Making sure CIs are passing

[ohltyler]

Overall great start, thanks a lot for helping! Generally just some syntax issues and best practices, no big concerns.

[jackiehanyang]

Thanks for the change! Two things I noticed from the screen recording:

1. I don't see dataSourceId= in the url on new_workflow page when local cluster is selected. Let's add that to keep all pages url in consistent when the feature flag is enabled
2. Could you click on the delete and link icon button on the Workflows page and to see if they all work as expected?

[ohltyler]

@saimedhi looking great! Once my remaining comments on public/route_service.ts are addressed and you can confirm all of the functionality is still working as expected, I am happy to approve :)

[saimedhi]

screen-capture.2.webm

[ohltyler]

Changes LGTM! One more request to add details in the PR description, including some of the low-level implementation details. See existing merged PRs as an example. This makes it much easier to track down issues that may come up in the future, and keeps a detailed log of what and when changes were made, and the motivation behind them.

[jackiehanyang]

Remote data source should be consistent in breadcrumbs. When go back to workflow page, local cluster should be selected instead of selecting the default data source. Could you address this bug?

[saimedhi]

Remote data source should be consistent in breadcrumbs. When go back to workflow page, local cluster should be selected instead of selecting the default data source. Could you address this bug?

@jackiehanyang, I will fix it in a followup PR. Thank you.

• I will make sure when we go back to workflow page, data source selected will be retained .

[jackiehanyang]

you don't need this props, and I don't see any usage of this props later. I have this for AD because AD has multiple pages. So I need this prop for AD to track the dataSourceId for landing pages to differentiate:

• if the page is opened as a landing page, we select the default remote data source
• if the page is opened by being redirected from another page, we keep the dataSourceId consistent as the previous page instead of selecting the default remote data source.

None of this is applicable to Flow Framework, so please remove unnecessary and unused props.

[jackiehanyang]

you don't need this flag. I see you always pass true here

[saimedhi]

Remote data source should be consistent in breadcrumbs. When go back to workflow page, local cluster should be selected instead of selecting the default data source. Could you address this bug?

@jackiehanyang, I will fix it in a followup PR. Thank you.

• I will make sure when we go back to workflow page, data source selected will be retained .

screen-capture.3.webm

[jackiehanyang]

I see a bug - when you opening flow framework from the side nav, default remote data source should be selected and the dataSourceId should exist in the url

Please thoroughly test the following scenarios:

• when you opening flow framework from the side nav, default remote data source should be selected
• when you opening flow framework from a bookmarked url, the data source that's in the url should be selected
• when you select a non default remote data source, it should still be selected if you refresh the page, instead of jumping back to the default one.
• data source should be consistent through breadcrumbs
• data source should be consistent through in-app side nav
• considering the project goals and customer perspective, test all possible workflows to ensure that multiple data sources are supported correctly.