[Page Header] New page header for applications and UI updates #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Aug 22, 2024
Comment on lines
140
to
141
| float: 'left', | ||
| width: '100%', |
There was a problem hiding this comment.
Are these needed anymore. Cause when we removed the mac width the other two css lines became irrelevant.
There was a problem hiding this comment.
Removed pageStyle, was also used in notebooks so was going to do it separately but removed from both.
ps48
reviewed
Aug 22, 2024
public/plugin_headerControl.tsx
Outdated
| return ( | ||
| <> | ||
| {components.map((component, index) => | ||
| React.cloneElement(component, { key: `component-fallback-${index}` }) |
There was a problem hiding this comment.
Why do we need clone element here? Also, why do we have this key named as component-fallback
There was a problem hiding this comment.
Removed now just using
return <>{components}</>;
ps48
reviewed
Aug 22, 2024
Comment on lines
523
to
536
| {!newNavigation && ( | ||
| <> | ||
| <EuiTitle size="l"> | ||
| <h1 data-test-subj="applicationTitle">{application.name}</h1> | ||
| </EuiTitle> | ||
| <EuiText> | ||
| <p>{application.description}</p> | ||
| </EuiText> | ||
| </> | ||
| )} | ||
| {newNavigation && ( | ||
| <HeaderControlledComponentsWrapper description={application.description} /> | ||
| )} | ||
| </EuiPageHeaderSection> |
There was a problem hiding this comment.
Nit. Would this be cleaner?
{newNavigation ?
(<HeaderControlledComponentsWrapper description={application.description} />)
: (
<>
<EuiTitle size="l">
<h1 data-test-subj="applicationTitle">{application.name}</h1>
</EuiTitle>
<EuiText>
<p>{application.description}</p>
</EuiText>
</>
)}
There was a problem hiding this comment.
Yes, have adjusted thank you
ps48
reviewed
Aug 22, 2024
| <div style={pageStyles}> | ||
| <> | ||
| {!newNavigation && ( | ||
| <div style={{ paddingLeft: '16px', paddingTop: '8px' }}> |
There was a problem hiding this comment.
Can may be remove these custom styles.
There was a problem hiding this comment.
Fixed with EuiPageHeader
added 3 commits
August 22, 2024 13:35
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
ps48
approved these changes
Aug 22, 2024
Swiddis
approved these changes
Aug 23, 2024
Signed-off-by: Adam Tackett <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2081-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd544f708d1aed95d2b4e2d7ae7c0eb45b37398a
# Push it to GitHub
git push --set-upstream origin backport/backport-2081-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.xThen, create a pull request where the |
TackAdam
added a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Aug 24, 2024
…arch-project#2081) * Page header updates for applications Signed-off-by: Adam Tackett <[email protected]> * small adjustments Signed-off-by: Adam Tackett <[email protected]> * update snapshots Signed-off-by: Adam Tackett <[email protected]> * update from comments Signed-off-by: Adam Tackett <[email protected]> * remove custom css Signed-off-by: Adam Tackett <[email protected]> * update snapshots from osd Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit dd544f7)
6 tasks
TackAdam
added a commit
that referenced
this pull request
Aug 26, 2024
…updates (#2081) (#2095) * [Page Header] New page header for applications and UI updates (#2081) * Page header updates for applications Signed-off-by: Adam Tackett <[email protected]> * small adjustments Signed-off-by: Adam Tackett <[email protected]> * update snapshots Signed-off-by: Adam Tackett <[email protected]> * update from comments Signed-off-by: Adam Tackett <[email protected]> * remove custom css Signed-off-by: Adam Tackett <[email protected]> * update snapshots from osd Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit dd544f7) * fixing lint errors Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Old Applications under new navigation:
After changes:
Old applications without new navigation:
After changes:
Video of new actions working (removed button and added to table):
Screen.Recording.2024-08-21.at.11.14.19.AM.mov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.