Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Page Header] New page header for applications and UI updates #2081

Merged
merged 8 commits into from
Aug 24, 2024
Merged

[Page Header] New page header for applications and UI updates #2081

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b58e0e
Page header updates for applications
Aug 21, 2024
c948279
small adjustments
Aug 21, 2024
56416fa
Merge branch 'main' into applicationUi
TackAdam Aug 22, 2024
13f7d46
update snapshots
Aug 22, 2024
6f591f0
update from comments
Aug 22, 2024
ef4cf3c
remove custom css
Aug 22, 2024
c4848e0
update snapshots from osd
Aug 22, 2024
e4db21b
Merge branch 'main' into applicationUi
TackAdam Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion common/constants/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ export const LONG_CHART_COLOR = PLOTLY_COLOR[1];
export const pageStyles: CSS.Properties = {
float: 'left',
width: '100%',
Comment on lines 140 to 141
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these needed anymore. Cause when we removed the mac width the other two css lines became irrelevant.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed pageStyle, was also used in notebooks so was going to do it separately but removed from both.

maxWidth: '1130px',
};

export enum VIS_CHART_TYPES {
Expand Down
Loading
Loading