Update custom traces table with filters #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Sep 20, 2024
| }, | ||
| ]; | ||
|
|
||
| export const TRACE_TABLE_TYPE_KEY = 'TraceAnalyticsTraceTableType'; |
There was a problem hiding this comment.
ideally the constants are in common only if they are shared between client (public) and server. if they are only used on one side they can go directly there
There was a problem hiding this comment.
That makes sense. Will keep this one here for now. Will sort out this and others in common/constants during a mini refactor.
public/components/trace_analytics/components/traces/trace_table_helpers.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/traces/traces_custom_indices_table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
vamsi-amazon
approved these changes
Sep 21, 2024
RyanL1997
approved these changes
Sep 23, 2024
| props.tracesTableMode, | ||
| getTraceViewUri, | ||
| openTraceFlyout, | ||
| items, |
There was a problem hiding this comment.
nit:
React Hook useMemo has an unnecessary dependency: 'items'. Either exclude it or remove the dependency array
public/components/trace_analytics/components/traces/trace_table_helpers.tsx
Show resolved
Hide resolved
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
force-pushed
the
trace_cs_table_fix
branch
from
bb121de
to
b6bc273
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
* update custom traces table with filters Signed-off-by: Shenoy Pratik <[email protected]> * use css truncate, resolve comments Signed-off-by: Shenoy Pratik <[email protected]> * add guards for execution_hint Signed-off-by: Shenoy Pratik <[email protected]> * update descriptions Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 00fd9ac) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 23, 2024
* update custom traces table with filters * use css truncate, resolve comments * add guards for execution_hint * update descriptions --------- (cherry picked from commit 00fd9ac) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorting and Pagination push down won’t be part of this PR.
Update custom traces table with filters added below:
Functional updates:
Issues Resolved
Default table view
Table filter options
Table showing trace root spans
Table showing attributes
Demo Video
traces-table-filter.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.