Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update custom traces table with filters #2178
Update custom traces table with filters #2178
Changes from 1 commit
fc78c82
15d3840
0ba456b
b6bc273
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally the constants are in
common
only if they are shared between client (public) and server. if they are only used on one side they can go directly thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Will keep this one here for now. Will sort out this and others in common/constants during a mini refactor.
Check warning on line 61 in public/components/trace_analytics/components/traces/trace_table_helpers.tsx
GitHub Actions / Lint
Check warning on line 171 in public/components/trace_analytics/components/traces/trace_table_helpers.tsx
GitHub Actions / Lint
Check warning on line 213 in public/components/trace_analytics/components/traces/trace_table_helpers.tsx
GitHub Actions / Lint
Check warning on line 234 in public/components/trace_analytics/components/traces/trace_table_helpers.tsx
GitHub Actions / Lint
Check warning on line 165 in public/components/trace_analytics/components/traces/traces_content.tsx
GitHub Actions / Lint