Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install editable NNCF in workflows #2054

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

vshampor
Copy link
Contributor

@vshampor vshampor commented Aug 17, 2023

Changes

Now doing pip install . instead of pip install -e . in GH Actions workflow files.

Reason for changes

Ubuntu 22 and pip/setuptools have a lot of bugs when installing editable packages with the new build isolation flow (e.g. when the pyproject.toml is present). We don't have pyproject.toml yet, but should we need to switch, better to have less failures in the unrelated tests and workflows - we don't really need editability in GH actions we have now.

Related tickets

N/A

Tests

Can only test changes in these workflows post-factum.

@vshampor vshampor requested a review from a team as a code owner August 17, 2023 07:57
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@8b71d39). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2054   +/-   ##
==========================================
  Coverage           ?   20.75%           
==========================================
  Files              ?      887           
  Lines              ?    82327           
  Branches           ?        0           
==========================================
  Hits               ?    17084           
  Misses             ?    65243           
  Partials           ?        0           

@vshampor vshampor merged commit de10012 into openvinotoolkit:develop Aug 17, 2023
6 checks passed
@vshampor vshampor deleted the no_editable_in_workflows branch January 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant