Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable preloading of subtitles in video.js #221

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Aug 3, 2024

Fixes #220

@kelson42 kelson42 requested a review from benoit74 August 3, 2024 09:54
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.03%. Comparing base (a586a69) to head (57069d0).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #221   +/-   ##
=====================================
  Coverage   5.03%   5.03%           
=====================================
  Files          8       8           
  Lines       1093    1093           
  Branches     238     238           
=====================================
  Hits          55      55           
  Misses      1037    1037           
  Partials       1       1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you tested this change? Especially with both HTML5 normal mode and with ogv.js fallback? Comparing this change with youtube one, it looks like it is not complete, we need to set the option for both tech.

@kelson42 kelson42 force-pushed the disable-subtitles-preloading branch from 9d39efd to 57069d0 Compare August 3, 2024 12:48
@kelson42
Copy link
Contributor Author

kelson42 commented Aug 3, 2024

@benoit74 Have updated the PR to complete my PR with html5 configuration. I don't have tested it yet as I never run the scraper... but that was the occasion and I'm currently running one...

@kelson42 kelson42 requested a review from benoit74 August 3, 2024 13:04
@kelson42
Copy link
Contributor Author

kelson42 commented Aug 3, 2024

@benoit74 Test result: it seems to work like expected. In the following screenshot, we see only the vietnamise subtitle loaded (at my demand):
image

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@benoit74 benoit74 merged commit 3d71c31 into main Aug 5, 2024
8 checks passed
@benoit74 benoit74 deleted the disable-subtitles-preloading branch August 5, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not preload subtitles in video.JS
2 participants