Bug/57305 sorting by custom field has strong impact on performance for the project list #16841
Conversation
toy
force-pushed
the
bug/57305-sorting-by-custom-field-has-strong-impact-on-performance-for-the-project-list
branch
4 times, most recently
from
f7fbb59
to
40034e9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
toy
force-pushed
the
bug/57305-sorting-by-custom-field-has-strong-impact-on-performance-for-the-project-list
branch
from
33ea0df
to
29dac54
Compare
toy
force-pushed
the
bug/57305-sorting-by-custom-field-has-strong-impact-on-performance-for-the-project-list
branch
4 times, most recently
from
74aaecc
to
73daf9f
Compare
| def summable_statement | ||
| if %w[float int].include?(custom_field.field_format) | ||
| select = summable_select_statement | ||
|
|
||
| ->(query, grouped) { | ||
| Queries::WorkPackages::Selects::WorkPackageSelect | ||
| .scoped_column_sum(summable_scope(query), select, grouped:, query:) | ||
| } | ||
| else | ||
| "COALESCE(ROUND(SUM(value::NUMERIC), 2)::FLOAT, 0.0) #{name}" | ||
| false | ||
| end | ||
| end |
There was a problem hiding this comment.
Diff may make it confusing, this is extracted from set_summable!
toy
force-pushed
the
bug/57305-sorting-by-custom-field-has-strong-impact-on-performance-for-the-project-list
branch
7 times, most recently
from
172eb20
to
3dcfa9c
Compare
Previously it relied on receiving empty string
toy
force-pushed
the
bug/57305-sorting-by-custom-field-has-strong-impact-on-performance-for-the-project-list
branch
from
89a556f
to
5bd80f6
Compare
There was a problem hiding this comment.
The change looks good functionality and also performance wise, in the tests I have conducted. It is now possible to group by way more fields which when looking at community is nice.
There are some issues with the added grouping options, though. Of those, the first is but a display issue. But the second one leads to entries being sorted into the wrong group.
Grouping by integer cf
Here, the grouping happens with an integer cf. The groups however are presented as floats.
Grouping by link cf
The backend correctly returns just one item in the group. The frontend still places more entries into the group.
|
|
||
| # Template for all the join statements. | ||
| # | ||
| # For single value custom fields thejoin ensures single value for every |
There was a problem hiding this comment.
Typo 'thejoin' -> 'the join'
Ticket
OP#57305 + OP#57554
What are you trying to accomplish?
Screenshots
What approach did you choose and why?
Merge checklist