Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/57305 sorting by custom field has strong impact on performance for the project list #16841

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open

Bug/57305 sorting by custom field has strong impact on performance for the project list #16841

wants to merge 26 commits into from

Commits on Oct 18, 2024

  1. [#57305] Sorting by custom field has strong impact on performance for… 

    … the project list

https://community.openproject.org/work_packages/57305
    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9201af8 View commit details
    Browse the repository at this point in the history

  2. remove unused option if from work package property select

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    de75198 View commit details
    Browse the repository at this point in the history

  3. using instance variables instead of writers for work package selects

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cfe36b6 View commit details
    Browse the repository at this point in the history

  4. inline set_xxx! methods in CustomFieldSelect

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3f4abec View commit details
    Browse the repository at this point in the history

  5. rename order_statements to order_statement swithcing it to return sin… 

    …gle statement
    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4fd686d View commit details
    Browse the repository at this point in the history

  6. apply null handling to ordering projects by custom field

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    19c4111 View commit details
    Browse the repository at this point in the history

  7. rename CustomField#null_handling to order_null_handling

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    059f844 View commit details
    Browse the repository at this point in the history

  8. using joins for custom field ordering, grouping should be broken

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    38b0992 View commit details
    Browse the repository at this point in the history

  9. move deciding which custom field can be grouped by to order statements

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ac45ea4 View commit details
    Browse the repository at this point in the history

  10. enable grouping by float, string and link too

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7d4668b View commit details
    Browse the repository at this point in the history

  11. remove replacing nil by false which doesn't seem to be needed

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    004ab35 View commit details
    Browse the repository at this point in the history

  12. handle joins for groupping by custom field

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bfc466b View commit details
    Browse the repository at this point in the history

  13. fix join statement for group by to return ids instead of positions

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    341be96 View commit details
    Browse the repository at this point in the history

  14. handle absent values in group by 

    Previously it relied on receiving empty string
    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6960db8 View commit details
    Browse the repository at this point in the history

  15. pass group_by_join_statement to WorkPackageSelect.scoped_column_sum

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ca87936 View commit details
    Browse the repository at this point in the history

  16. disambigute value in summable_select_statement

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    74d1286 View commit details
    Browse the repository at this point in the history

  17. use receive_messages as rubocop suggests

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b482958 View commit details
    Browse the repository at this point in the history

  18. deduplicate queries using template

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b32f241 View commit details
    Browse the repository at this point in the history

  19. ensure group_by_join_statement is nil when group_by_statement is nil

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5266817 View commit details
    Browse the repository at this point in the history

  20. order empty values before present values for all custom field formats

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    47c97a0 View commit details
    Browse the repository at this point in the history

  21. fix order of list custom field groups to be same as when ordering

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f754b0e View commit details
    Browse the repository at this point in the history

  22. use MIN instead of ANY_VALUE, as latter is available only in PostgreS… 

    …QL 16
    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    383c5f4 View commit details
    Browse the repository at this point in the history

  23. fix columns used in summing

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aa9f044 View commit details
    Browse the repository at this point in the history

  24. use group_id instead of id to name the column used to group from summing

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    af97ea2 View commit details
    Browse the repository at this point in the history

  25. extract method to calm rubocop

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f8d9195 View commit details
    Browse the repository at this point in the history

  26. add resulting join sqls from template in comment

    @toy
    toy committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5bd80f6 View commit details
    Browse the repository at this point in the history