Add an enterprise banner on top of automatic subject configuration #17506
Conversation
lib/open_project/static/links.rb
Outdated
| @@ -251,6 +251,9 @@ def static_links | |||
| href: "https://www.openproject.org/docs/user-guide/time-and-costs/progress-tracking/" | |||
| }, | |||
| enterprise_docs: { | |||
| automatic_subject_generation: { | |||
| href: "https://www.openproject.org/docs/todo/do-not-merge" | |||
There was a problem hiding this comment.
Can we already know/guess the correct URL this will have in the future? Otherwise we'll need to remember to revisit this link and fix it before public release.
There was a problem hiding this comment.
This needs to be discussed with Maya. Maybe she can predict it, if not, we need to put a placeholder.
There was a problem hiding this comment.
Aligned with @MayaBerd and added a small placeholder into the docs already and pointed to the correct place.
Note: We should now not merge this branch before todays feature freeze (so that the docs are not updated before 15.3).
(Alternatively if we need to merge this today because of dependencies or what not --> just remove the text from the docs and we are safe as well)
NobodysNightmare
force-pushed
the
subject-enterprise-banner
branch
from
7f9bb0f to
ade9446
Compare
|
@ulferts Not sure, but this might be the first time that we use the new banner component 🎉 As can be seen in the screenshot above, there should be additional space between the banner and the form. Do you think this is something that I should fix on a "this usage only" basis (e.g. by figuring out how to use |
|
I talked to @HDinger in your absence. She expressed a preference in leaving margins/paddings out of the component and defining this on a case-by-case basis |
NobodysNightmare
force-pushed
the
subject-enterprise-banner
branch
2 times, most recently
from
f3b4acb to
667902a
Compare
Adding a test selector that can be used to detect the presence of the enterprise banner in other specs and improving the docs from non-default values.
NobodysNightmare
force-pushed
the
subject-enterprise-banner
branch
from
667902a to
89c59d9
Compare
We are making sure that users can revert back to manual subjects at any time and even keep using the feature if it's still enabled after their enterprise token expired. They will merely not be able to set new types to automatic and have to live with an enterprise banner being shown to them whenever they change the subject config.
NobodysNightmare
force-pushed
the
subject-enterprise-banner
branch
from
89c59d9 to
9a8ad7b
Compare
We are making sure that users can revert back to manual subjects at any time and even keep using the feature if it's still enabled after their enterprise token expired. They will merely not be able to set new types to automatic and have to live with an enterprise banner being shown to them whenever they change the subject config.
Ticket
https://community.openproject.org/projects/document-workflows-stream/work_packages/59929
What are you trying to accomplish?
Show users that this feature is enterprise-exclusive, while retaining their ability to use the feature (or stop using it) once their EE license has expired
Screenshots
What approach did you choose and why?
Our new standard component for EE banners, because standardization is great!
Merge checklist