Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reboot handler improvements #457

Merged
merged 18 commits into from
May 1, 2024
Merged

Reboot handler improvements #457

merged 18 commits into from
May 1, 2024

Conversation

ThiloSolbrig
Copy link
Contributor

  • Replaces orahost's strict reboot handler by configurable reboot of global_handlers
  • Add's reboot recommendation check after package installs

@ThiloSolbrig ThiloSolbrig mentioned this pull request Apr 26, 2024
Closed
@Rendanic Rendanic added this to the 4.9 milestone Apr 26, 2024
@Rendanic Rendanic linked an issue Apr 26, 2024 that may be closed by this pull request
Check system for reboot recommendation after package updates #456
Closed
@Rendanic
Copy link
Collaborator

This is a breaking change for ansible-oracle, because the target system is rebootet during execution of common-role, when kernel update is installed.
This could lead to unexpected reboots of a running database server.

I think this is not a good idea.

Solution:
Change to no reboot by default, but this require a change in global_handlers, because restart_on_requirement=true is read from role defaults.

@Rendanic Rendanic merged commit 39639be into oravirt:master May 1, 2024
6 checks passed
Rendanic added a commit to Rendanic/ansible-oracle that referenced this pull request Jul 22, 2024
@Rendanic
Release 4.9.0 - 1st production Release of ansible-oracle
4d73879 
v4.9.0
======

Release Summary
---------------

This is the 1st production release of ansible-oracle 4.x.
The RAC support was the last missing option in 4.x compared to 3.12.0.
A documentation for migration from 3.12.0 to 4.x is work in progress.

Minor Changes
-------------

- added option to disable transparent hugepages in grub (oravirt#460)
- bugfix set custom environment for executables with oracle_script_env (oravirt#458)
- global_handlers: Introduce a global handlers role (oravirt#455)
- global_handlers: Reboot handler improvements, restart_on_requirement=false, ansible-lint (oravirt#457)
- molecule: added MOLECULE_IMAGE for custom images and support for SuSE (oravirt#458)
- oracle_opatch.py needs to support configurable temp directory  (oravirt#462)
- orahost: Add a list of additional hosts to /etc/hosts (oravirt#447)
- orahost: add oracle_sysctl_file and oracle_hugepages_sysctl_file variables (oravirt#432)
- orahost: set vm.hugetlb_shm_group to oracle user GID (oravirt#461)
- orahost_logrotate: logrotate setup for oracle files should be optional (oravirt#449)
- orahost_meta: Enable calculation of several kernel parameters (oravirt#451)
- orahost_meta: added oracle_tmp_stage for hardened systems (oravirt#453)
- oraswdb_manage_patches: make role compatible with oraswgi_manage_patches (oravirt#464)
- oraswgi_install: Next refactoring of role for RAC (oravirt#464)
- set custom environment for executables with oracle_script_env (oravirt#453)

Breaking Changes / Porting Guide
--------------------------------

- CV_ASSUME_DISTID: SLES15 when ansible_os_family == 'SuSE' (oravirt#458)
- oraswgi_manage_patches: python-module xmltodict needed on ansible-controller (oravirt#464)

Bugfixes
--------

- Consider home was removed earlier, leaving REMOVED=T (oravirt#437)
- bugfix: added apply_patches_gi to some tasks with patch_before_rootsh (oravirt#464)
- default_gipass is not required if sysasmpassword and asmmonitorpassword are set (oravirt#433)
- fixed jinja spacing warning (oravirt#463)
- oracluvfy did not fail when error was detected (oravirt#464)
- orasw_meta: grid_base != oracle_base only required if role_separation=true (oravirt#439)
- oraswdb_install: Configure systemd only for Single Instance without GI/Restart (oravirt#431)
- oraswgi_install: honour deploy_ocenv setting (oravirt#443)
@Rendanic Rendanic mentioned this pull request Jul 22, 2024
Merged
Rendanic added a commit that referenced this pull request Aug 10, 2024
@Rendanic
Release 4.9.0 - 1st production Release of ansible-oracle
db6998e 
v4.9.0
======

Release Summary
---------------

This is the 1st production release of ansible-oracle 4.x.
The RAC support was the last missing option in 4.x compared to 3.12.0.
A documentation for migration from 3.12.0 to 4.x is work in progress.

Minor Changes
-------------

- added option to disable transparent hugepages in grub (#460)
- bugfix set custom environment for executables with oracle_script_env (#458)
- global_handlers: Introduce a global handlers role (#455)
- global_handlers: Reboot handler improvements, restart_on_requirement=false, ansible-lint (#457)
- molecule: added MOLECULE_IMAGE for custom images and support for SuSE (#458)
- oracle_opatch.py needs to support configurable temp directory  (#462)
- orahost: Add a list of additional hosts to /etc/hosts (#447)
- orahost: add oracle_sysctl_file and oracle_hugepages_sysctl_file variables (#432)
- orahost: set vm.hugetlb_shm_group to oracle user GID (#461)
- orahost_logrotate: logrotate setup for oracle files should be optional (#449)
- orahost_meta: Enable calculation of several kernel parameters (#451)
- orahost_meta: added oracle_tmp_stage for hardened systems (#453)
- oraswdb_manage_patches: make role compatible with oraswgi_manage_patches (#464)
- oraswgi_install: Next refactoring of role for RAC (#464)
- set custom environment for executables with oracle_script_env (#453)

Breaking Changes / Porting Guide
--------------------------------

- CV_ASSUME_DISTID: SLES15 when ansible_os_family == 'SuSE' (#458)
- oraswgi_manage_patches: python-module xmltodict needed on ansible-controller (#464)

Bugfixes
--------

- Consider home was removed earlier, leaving REMOVED=T (#437)
- bugfix: added apply_patches_gi to some tasks with patch_before_rootsh (#464)
- default_gipass is not required if sysasmpassword and asmmonitorpassword are set (#433)
- fixed jinja spacing warning (#463)
- oracluvfy did not fail when error was detected (#464)
- orasw_meta: grid_base != oracle_base only required if role_separation=true (#439)
- oraswdb_install: Configure systemd only for Single Instance without GI/Restart (#431)
- oraswgi_install: honour deploy_ocenv setting (#443)
Rendanic added a commit to Rendanic/ansible-oracle that referenced this pull request Aug 11, 2024
@Rendanic
Release 4.9.0 - 1st production Release of ansible-oracle
a232af5 
v4.9.0
======

Release Summary
---------------

This is the 1st production release of ansible-oracle 4.x.
The RAC support was the last missing option in 4.x compared to 3.12.0.
A documentation for migration from 3.12.0 to 4.x is work in progress.

Minor Changes
-------------

- added option to disable transparent hugepages in grub (oravirt#460)
- bugfix set custom environment for executables with oracle_script_env (oravirt#458)
- global_handlers: Introduce a global handlers role (oravirt#455)
- global_handlers: Reboot handler improvements, restart_on_requirement=false, ansible-lint (oravirt#457)
- molecule: added MOLECULE_IMAGE for custom images and support for SuSE (oravirt#458)
- oracle_opatch.py needs to support configurable temp directory  (oravirt#462)
- orahost: Add a list of additional hosts to /etc/hosts (oravirt#447)
- orahost: add oracle_sysctl_file and oracle_hugepages_sysctl_file variables (oravirt#432)
- orahost: set vm.hugetlb_shm_group to oracle user GID (oravirt#461)
- orahost_logrotate: logrotate setup for oracle files should be optional (oravirt#449)
- orahost_meta: Enable calculation of several kernel parameters (oravirt#451)
- orahost_meta: added oracle_tmp_stage for hardened systems (oravirt#453)
- oraswdb_manage_patches: make role compatible with oraswgi_manage_patches (oravirt#464)
- oraswgi_install: Next refactoring of role for RAC (oravirt#464)
- set custom environment for executables with oracle_script_env (oravirt#453)

Breaking Changes / Porting Guide
--------------------------------

- CV_ASSUME_DISTID: SLES15 when ansible_os_family == 'SuSE' (oravirt#458)
- oraswgi_manage_patches: python-module xmltodict needed on ansible-controller (oravirt#464)

Bugfixes
--------

- Consider home was removed earlier, leaving REMOVED=T (oravirt#437)
- bugfix: added apply_patches_gi to some tasks with patch_before_rootsh (oravirt#464)
- default_gipass is not required if sysasmpassword and asmmonitorpassword are set (oravirt#433)
- fixed jinja spacing warning (oravirt#463)
- oracluvfy did not fail when error was detected (oravirt#464)
- orasw_meta: grid_base != oracle_base only required if role_separation=true (oravirt#439)
- oraswdb_install: Configure systemd only for Single Instance without GI/Restart (oravirt#431)
- oraswgi_install: honour deploy_ocenv setting (oravirt#443)
Rendanic added a commit to Rendanic/ansible-oracle that referenced this pull request Aug 11, 2024
@Rendanic
Release 4.9.0 - 1st production Release of ansible-oracle
c1f028a 
v4.9.0
======

Release Summary
---------------

This is the 1st production release of ansible-oracle 4.x.
The RAC support was the last missing option in 4.x compared to 3.12.0.
A documentation for migration from 3.12.0 to 4.x is work in progress.

Minor Changes
-------------

- added option to disable transparent hugepages in grub (oravirt#460)
- bugfix set custom environment for executables with oracle_script_env (oravirt#458)
- global_handlers: Introduce a global handlers role (oravirt#455)
- global_handlers: Reboot handler improvements, restart_on_requirement=false, ansible-lint (oravirt#457)
- molecule: added MOLECULE_IMAGE for custom images and support for SuSE (oravirt#458)
- oracle_opatch.py needs to support configurable temp directory  (oravirt#462)
- orahost: Add a list of additional hosts to /etc/hosts (oravirt#447)
- orahost: add oracle_sysctl_file and oracle_hugepages_sysctl_file variables (oravirt#432)
- orahost: set vm.hugetlb_shm_group to oracle user GID (oravirt#461)
- orahost_logrotate: logrotate setup for oracle files should be optional (oravirt#449)
- orahost_meta: Enable calculation of several kernel parameters (oravirt#451)
- orahost_meta: added oracle_tmp_stage for hardened systems (oravirt#453)
- oraswdb_manage_patches: make role compatible with oraswgi_manage_patches (oravirt#464)
- oraswgi_install: Next refactoring of role for RAC (oravirt#464)
- set custom environment for executables with oracle_script_env (oravirt#453)

Breaking Changes / Porting Guide
--------------------------------

- CV_ASSUME_DISTID: SLES15 when ansible_os_family == 'SuSE' (oravirt#458)
- oraswgi_manage_patches: python-module xmltodict needed on ansible-controller (oravirt#464)

Bugfixes
--------

- Consider home was removed earlier, leaving REMOVED=T (oravirt#437)
- bugfix: added apply_patches_gi to some tasks with patch_before_rootsh (oravirt#464)
- default_gipass is not required if sysasmpassword and asmmonitorpassword are set (oravirt#433)
- fixed jinja spacing warning (oravirt#463)
- oracluvfy did not fail when error was detected (oravirt#464)
- orasw_meta: grid_base != oracle_base only required if role_separation=true (oravirt#439)
- oraswdb_install: Configure systemd only for Single Instance without GI/Restart (oravirt#431)
- oraswgi_install: honour deploy_ocenv setting (oravirt#443)
@ThiloSolbrig ThiloSolbrig deleted the enhancement#456-conditional-reboot branch September 18, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement incompatble change
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Check system for reboot recommendation after package updates
2 participants
@ThiloSolbrig @Rendanic