oravirt · Rendanic · May 1, 2024 · Apr 23, 2024 · Apr 23, 2024 · Apr 23, 2024
diff --git a/changelogs/fragments/global_handler_lint.yml b/changelogs/fragments/global_handler_lint.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - "global_handlers: Reboot handler improvements, restart_on_requirement=false, ansible-lint (oravirt#457)"
diff --git a/roles/common/README.md b/roles/common/README.md
@@ -421,7 +421,7 @@ ol7_repo_file: public-yum-ol7.repo
 
 ## Dependencies
 
-None.
+- global_handlers
 
 ## License
 

diff --git a/roles/common/meta/main.yml b/roles/common/meta/main.yml
@@ -24,4 +24,5 @@ galaxy_info:
 
   galaxy_tags: []
 
-dependencies: []
+dependencies:
+  - role: global_handlers
diff --git a/roles/common/tasks/RedHat.yml b/roles/common/tasks/RedHat.yml
@@ -50,3 +50,4 @@
     - install_os_packages
   tags:
     - commonpackages
+  notify: Reboot concerning package updates
diff --git a/roles/common/tasks/Suse.yml b/roles/common/tasks/Suse.yml
@@ -7,3 +7,4 @@
     - install_os_packages
   tags:
     - commonpackages
+  notify: Reboot concerning package updates
diff --git a/roles/global_handlers/README.md b/roles/global_handlers/README.md
@@ -32,7 +32,7 @@ or just displays a reboot advice (false)
 #### Default value
 
 ```YAML
-restart_on_requirement: true
+restart_on_requirement: false
 ```
 
 

diff --git a/roles/global_handlers/defaults/main.yml b/roles/global_handlers/defaults/main.yml
@@ -4,4 +4,4 @@
 # or just displays a reboot advice (false)
 # @end
 # @var restart_on_requirement:type: bool
-restart_on_requirement: true
+restart_on_requirement: false
diff --git a/roles/global_handlers/handlers/main.yml b/roles/global_handlers/handlers/main.yml
@@ -1,11 +1,12 @@
 ---
 - name: Reboot concerning package updates
-  ansible.builtin.command:
-    "{%- if ansible_facts.os_family == 'RedHat' -%}
-      yum needs-restarting -r
-    {%- elif ansible_facts.os_family == 'Suse' -%}
-      zypper needs-rebooting
-    {%- endif -%}"
+  ansible.builtin.command: >-
+    {% if ansible_facts.os_family == 'RedHat' -%}
+    yum needs-restarting -r
+    {% elif ansible_facts.os_family == 'Suse' -%}
+    zypper needs-rebooting
+    {% endif -%}
+
   failed_when: false
   register: _global_handlers_needs_restarting
   changed_when: _global_handlers_needs_restarting.rc > 0
@@ -17,8 +18,9 @@
       when: restart_on_requirement
       listen: restart server
       ansible.builtin.reboot:
+
     - name: Reboot recommendation
       when: not restart_on_requirement
       listen: restart server
       ansible.builtin.debug:
-        msg: Please REBOOT {{ ansible_hostname }} for modifications to take effect.
+        msg: "Please REBOOT {{ ansible_hostname }} for modifications to take effect."
diff --git a/roles/orahost/README.md b/roles/orahost/README.md
@@ -866,6 +866,7 @@ transparent_hugepage_disable:
 
 ## Dependencies
 
+- global_handlers
 - orahost_meta
 
 ## License

diff --git a/roles/orahost/handlers/main.yml b/roles/orahost/handlers/main.yml
@@ -4,10 +4,6 @@
     name: network
     state: restarted
 
-- name: restart server
-  ansible.builtin.command: reboot
-  # noqa no-changed-when
-
 - name: swapon
   ansible.builtin.command: swapon -a
   # noqa no-changed-when
diff --git a/roles/orahost/meta/main.yml b/roles/orahost/meta/main.yml
@@ -25,4 +25,5 @@ galaxy_info:
   galaxy_tags: []
 
 dependencies:
+  - role: global_handlers
   - role: orahost_meta
diff --git a/roles/orahost/tasks/RedHat.yml b/roles/orahost/tasks/RedHat.yml
@@ -10,6 +10,7 @@
     - install_os_packages
     - ansible_distribution_major_version is version('7', '<=')
   tags: os_packages, oscheck
+  notify: Reboot concerning package updates
 
 - name: Install packages required by Oracle for ASMlib on OL/RHEL
   ansible.builtin.yum:
@@ -22,6 +23,7 @@
     - device_persistence == 'asmlib'
     - asm_diskgroups is defined
   tags: os_packages, oscheck
+  notify: Reboot concerning package updates
 
 - name: Disable Firewall
   when:

diff --git a/roles/orahost/tasks/Suse.yml b/roles/orahost/tasks/Suse.yml
@@ -8,6 +8,7 @@
     - install_os_packages
     - ansible_os_family == 'Suse'
   tags: os_packages, oscheck
+  notify: Reboot concerning package updates
 
 - name: Install default packages required by Oracle on SLES (version dependant)
   community.general.zypper:
@@ -23,6 +24,7 @@
     - ansible_os_family == 'Suse'
     - item.condition | default(false)
   tags: os_packages, oscheck
+  notify: Reboot concerning package updates
 
 - name: Install packages required by Oracle for ASMlib on SLES
   community.general.zypper:
@@ -33,6 +35,7 @@
     - device_persistence == 'asmlib'
     - asm_diskgroups is defined
   tags: os_packages, oscheck, asm1
+  notify: Reboot concerning package updates
 
 - name: Disable Transparent Hugepages (runtime)
   ansible.builtin.shell: |